leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fs: btrfs: Fix wrong comparison in logical to physical mapping

Browse Source 
The comparison
  logical > item->logical + item->length
in btrfs_map_logical_to_physical is wrong and should be instead
  logical >= item->logical + item->length
For example, if
  item->logical = 4096
  item->length = 4096
and we are looking for logical = 8192, it is not part of item (item is
[4096, 8191]). But the comparison is false and we think we have found
the correct item, although we should be searing in the right subtree.

This fixes some bugs I encountered.

Signed-off-by: Marek Behun <marek.behun@nic.cz>
This commit is contained in:
Marek Behún 2018-07-04 20:23:01 +02:00 committed by Tom Rini
parent 25dabd730a
commit f8c173b6a0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/btrfs/chunk-map.c
View File

@ -78,7 +78,7 @@ u64 btrfs_map_logical_to_physical(u64 logical)
if (item->logical > logical)
node = node->rb_left;
else if (logical > item->logical + item->length)
else if (logical >= item->logical + item->length)
node = node->rb_right;
else
return item->physical + logical - item->logical;