leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fdt_support: fix an endian bug of fdt_initrd()

Browse Source 
Data written to DTB must be converted to big endian order.
It is usually done by using cpu_to_fdt32(), cpu_to_fdt64(), etc.

fdt_initrd() invoked write_cell(), which always swaps byte order.
It means the function only worked on little endian architectures.
(On big endian architectures, the byte order should be kept as it is)

This commit uses cpu_to_fdt32() and cpu_to_fdt64()
and deletes write_cell().

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Acked-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Masahiro Yamada 2014-04-18 17:41:04 +09:00 committed by Tom Rini
parent 739a01ed8e
commit f18295d383
1 changed files with 20 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
common/fdt_support.c
View File

@ -32,18 +32,6 @@ static int get_cells_len(const void *fdt, const char *nr_cells_name)
return 4;
}
/*
* Write a 4 or 8 byte big endian cell
*/
static void write_cell(u8 *addr, u64 val, int size)
{
int shift = (size - 1) * 8;
while (size-- > 0) {
*addr++ = (val >> shift) & 0xff;
shift -= 8;
}
}
/**
* fdt_getprop_u32_default_node - Return a node's property or a default
*
@ -212,11 +200,21 @@ static int fdt_fixup_stdout(void *fdt, int chosenoff)
}
#endif
static inline int fdt_setprop_uxx(void *fdt, int nodeoffset, const char *name,
uint64_t val, int is_u64)
{
if (is_u64)
return fdt_setprop_u64(fdt, nodeoffset, name, val);
else
return fdt_setprop_u32(fdt, nodeoffset, name, (uint32_t)val);
}
int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end)
{
int nodeoffset, addr_cell_len;
int nodeoffset;
int err, j, total;
fdt64_t tmp;
int is_u64;
uint64_t addr, size;
/* find or create "/chosen" node. */
@ -248,19 +246,20 @@ int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end)
return err;
}
addr_cell_len = get_cells_len(fdt, "#address-cells");
is_u64 = (get_cells_len(fdt, "#address-cells") == 8);
err = fdt_setprop_uxx(fdt, nodeoffset, "linux,initrd-start",
(uint64_t)initrd_start, is_u64);
write_cell((u8 *)&tmp, initrd_start, addr_cell_len);
err = fdt_setprop(fdt, nodeoffset,
"linux,initrd-start", &tmp, addr_cell_len);
if (err < 0) {
printf("WARNING: could not set linux,initrd-start %s.\n",
fdt_strerror(err));
return err;
}
write_cell((u8 *)&tmp, initrd_end, addr_cell_len);
err = fdt_setprop(fdt, nodeoffset,
"linux,initrd-end", &tmp, addr_cell_len);
err = fdt_setprop_uxx(fdt, nodeoffset, "linux,initrd-end",
(uint64_t)initrd_end, is_u64);
if (err < 0) {
printf("WARNING: could not set linux,initrd-end %s.\n",
fdt_strerror(err));