leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

serial: bcm283x_mu: make pending values more explicit

Browse Source 
dm_serial_ops.pending should return the number of characters, not just a
valid C Boolean integer value. The existing code does already does this,
but only as an accident since BCM283X_MU_LSR_RX_READY happens to be
BIT(0). Enhance the code to be more explicit about the values it returns.

Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
This commit is contained in:
Stephen Warren 2016-04-13 22:29:52 -06:00 committed by Tom Rini
parent 28983f4b1a
commit e3a46e3ee2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/serial/serial_bcm283x_mu.c
View File

@ -116,9 +116,9 @@ static int bcm283x_mu_serial_pending(struct udevice *dev, bool input)
if (input) {
WATCHDOG_RESET();
return lsr & BCM283X_MU_LSR_RX_READY;
return (lsr & BCM283X_MU_LSR_RX_READY) ? 1 : 0;
} else {
return !(lsr & BCM283X_MU_LSR_TX_IDLE);
return (lsr & BCM283X_MU_LSR_TX_IDLE) ? 0 : 1;
}
}