leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

power: pmic: Correct debug/error output

Browse Source 
There is a newline missing from quite a few printf() strings in these pmic
files. Fix them.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
This commit is contained in:
Simon Glass 2018-11-18 08:14:28 -07:00
parent 7cbd2d2e32
commit c83c436de0
18 changed files with 56 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/power/pmic/act8846.c
View File

@ -50,7 +50,7 @@ static int act8846_bind(struct udevice *dev)
regulators_node = dev_read_subnode(dev, "regulators");
if (!ofnode_valid(regulators_node)) {
debug("%s: %s regulators subnode not found!", __func__,
debug("%s: %s regulators subnode not found!\n", __func__,
dev->name);
return -ENXIO;
}

14
drivers/power/pmic/as3722.c
View File

@ -45,14 +45,14 @@ static int as3722_read_id(struct udevice *dev, uint *idp, uint *revisionp)
ret = pmic_reg_read(dev, AS3722_ASIC_ID1);
if (ret < 0) {
pr_err("failed to read ID1 register: %d", ret);
pr_err("failed to read ID1 register: %d\n", ret);
return ret;
}
*idp = ret;
ret = pmic_reg_read(dev, AS3722_ASIC_ID2);
if (ret < 0) {
pr_err("failed to read ID2 register: %d", ret);
pr_err("failed to read ID2 register: %d\n", ret);
return ret;
}
*revisionp = ret;
@ -70,7 +70,7 @@ int as3722_sd_set_voltage(struct udevice *dev, unsigned int sd, u8 value)
ret = pmic_reg_write(dev, AS3722_SD_VOLTAGE(sd), value);
if (ret < 0) {
pr_err("failed to write SD%u voltage register: %d", sd, ret);
pr_err("failed to write SD%u voltage register: %d\n", sd, ret);
return ret;
}
@ -86,8 +86,8 @@ int as3722_ldo_set_voltage(struct udevice *dev, unsigned int ldo, u8 value)
ret = pmic_reg_write(dev, AS3722_LDO_VOLTAGE(ldo), value);
if (ret < 0) {
pr_err("failed to write LDO%u voltage register: %d", ldo,
ret);
pr_err("failed to write LDO%u voltage register: %d\n", ldo,
ret);
return ret;
}
@ -101,12 +101,12 @@ static int as3722_probe(struct udevice *dev)
ret = as3722_read_id(dev, &id, &revision);
if (ret < 0) {
pr_err("failed to read ID: %d", ret);
pr_err("failed to read ID: %d\n", ret);
return ret;
}
if (id != AS3722_DEVICE_ID) {
pr_err("unknown device");
pr_err("unknown device\n");
return -ENOENT;
}

11
drivers/power/pmic/as3722_gpio.c
View File

@ -25,7 +25,7 @@ int as3722_gpio_configure(struct udevice *pmic, unsigned int gpio,
err = pmic_reg_write(pmic, AS3722_GPIO_CONTROL(gpio), value);
if (err) {
pr_err("failed to configure GPIO#%u: %d", gpio, err);
pr_err("failed to configure GPIO#%u: %d\n", gpio, err);
return err;
}
@ -45,7 +45,7 @@ static int as3722_gpio_set_value(struct udevice *dev, unsigned int gpio,
err = pmic_reg_read(pmic, AS3722_GPIO_SIGNAL_OUT);
if (err < 0) {
pr_err("failed to read GPIO signal out register: %d", err);
pr_err("failed to read GPIO signal out register: %d\n", err);
return err;
}
value = err;
@ -60,7 +60,7 @@ static int as3722_gpio_set_value(struct udevice *dev, unsigned int gpio,
err = pmic_reg_write(pmic, AS3722_GPIO_SIGNAL_OUT, value);
if (err) {
pr_err("failed to set GPIO#%u %s: %d", gpio, l, err);
pr_err("failed to set GPIO#%u %s: %d\n", gpio, l, err);
return err;
}
@ -83,13 +83,14 @@ int as3722_gpio_direction_output(struct udevice *dev, unsigned int gpio,
err = pmic_reg_write(pmic, AS3722_GPIO_CONTROL(gpio), value);
if (err) {
pr_err("failed to configure GPIO#%u as output: %d", gpio, err);
pr_err("failed to configure GPIO#%u as output: %d\n", gpio,
err);
return err;
}
err = as3722_gpio_set_value(pmic, gpio, value);
if (err < 0) {
pr_err("failed to set GPIO#%u high: %d", gpio, err);
pr_err("failed to set GPIO#%u high: %d\n", gpio, err);
return err;
}

6
drivers/power/pmic/lp873x.c
View File

@ -24,7 +24,7 @@ static int lp873x_write(struct udevice *dev, uint reg, const uint8_t *buff,
int len)
{
if (dm_i2c_write(dev, reg, buff, len)) {
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -34,7 +34,7 @@ static int lp873x_write(struct udevice *dev, uint reg, const uint8_t *buff,
static int lp873x_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
{
if (dm_i2c_read(dev, reg, buff, len)) {
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -48,7 +48,7 @@ static int lp873x_bind(struct udevice *dev)
regulators_node = dev_read_subnode(dev, "regulators");
if (!ofnode_valid(regulators_node)) {
debug("%s: %s regulators subnode not found!", __func__,
debug("%s: %s regulators subnode not found!\n", __func__,
dev->name);
return -ENXIO;
}

6
drivers/power/pmic/lp87565.c
View File

@ -26,7 +26,7 @@ static int lp87565_write(struct udevice *dev, uint reg, const uint8_t *buff,
ret = dm_i2c_write(dev, reg, buff, len);
if (ret)
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -37,7 +37,7 @@ static int lp87565_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
ret = dm_i2c_read(dev, reg, buff, len);
if (ret)
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -49,7 +49,7 @@ static int lp87565_bind(struct udevice *dev)
regulators_node = dev_read_subnode(dev, "regulators");
if (!ofnode_valid(regulators_node)) {
debug("%s: %s regulators subnode not found!", __func__,
debug("%s: %s regulators subnode not found!\n", __func__,
dev->name);
return -ENXIO;
}

8
drivers/power/pmic/max77686.c
View File

@ -28,7 +28,7 @@ static int max77686_write(struct udevice *dev, uint reg, const uint8_t *buff,
int len)
{
if (dm_i2c_write(dev, reg, buff, len)) {
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -38,7 +38,7 @@ static int max77686_write(struct udevice *dev, uint reg, const uint8_t *buff,
static int max77686_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
{
if (dm_i2c_read(dev, reg, buff, len)) {
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -52,8 +52,8 @@ static int max77686_bind(struct udevice *dev)
regulators_node = dev_read_subnode(dev, "voltage-regulators");
if (!ofnode_valid(regulators_node)) {
debug("%s: %s regulators subnode not found!", __func__,
dev->name);
debug("%s: %s regulators subnode not found!\n", __func__,
dev->name);
return -ENXIO;
}

4
drivers/power/pmic/max8997.c
View File

@ -23,7 +23,7 @@ static int max8997_write(struct udevice *dev, uint reg, const uint8_t *buff,
ret = dm_i2c_write(dev, reg, buff, len);
if (ret)
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -34,7 +34,7 @@ static int max8997_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
ret = dm_i2c_read(dev, reg, buff, len);
if (ret)
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return ret;
}

4
drivers/power/pmic/max8998.c
View File

@ -23,7 +23,7 @@ static int max8998_write(struct udevice *dev, uint reg, const uint8_t *buff,
ret = dm_i2c_write(dev, reg, buff, len);
if (ret)
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -34,7 +34,7 @@ static int max8998_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
ret = dm_i2c_read(dev, reg, buff, len);
if (ret)
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return ret;
}

4
drivers/power/pmic/mc34708.c
View File

@ -38,7 +38,7 @@ static int mc34708_write(struct udevice *dev, uint reg, const u8 *buff,
ret = dm_i2c_write(dev, reg, buf, len);
if (ret)
printf("write error to device: %p register: %#x!", dev, reg);
printf("write error to device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -53,7 +53,7 @@ static int mc34708_read(struct udevice *dev, uint reg, u8 *buff, int len)
ret = dm_i2c_read(dev, reg, buf, len);
if (ret)
printf("read error from device: %p register: %#x!", dev, reg);
printf("read error from device: %p register: %#x!\n", dev, reg);
buff[0] = buf[2];
buff[1] = buf[1];

8
drivers/power/pmic/palmas.c
View File

@ -24,7 +24,7 @@ static int palmas_write(struct udevice *dev, uint reg, const uint8_t *buff,
int len)
{
if (dm_i2c_write(dev, reg, buff, len)) {
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -34,7 +34,7 @@ static int palmas_write(struct udevice *dev, uint reg, const uint8_t *buff,
static int palmas_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
{
if (dm_i2c_read(dev, reg, buff, len)) {
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -60,14 +60,14 @@ static int palmas_bind(struct udevice *dev)
}
if (!ofnode_valid(pmic_node)) {
debug("%s: %s pmic subnode not found!", __func__, dev->name);
debug("%s: %s pmic subnode not found!\n", __func__, dev->name);
return -ENXIO;
}
regulators_node = ofnode_find_subnode(pmic_node, "regulators");
if (!ofnode_valid(regulators_node)) {
debug("%s: %s reg subnode not found!", __func__, dev->name);
debug("%s: %s reg subnode not found!\n", __func__, dev->name);
return -ENXIO;
}

6
drivers/power/pmic/pfuze100.c
View File

@ -31,7 +31,7 @@ static int pfuze100_write(struct udevice *dev, uint reg, const uint8_t *buff,
int len)
{
if (dm_i2c_write(dev, reg, buff, len)) {
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -41,7 +41,7 @@ static int pfuze100_write(struct udevice *dev, uint reg, const uint8_t *buff,
static int pfuze100_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
{
if (dm_i2c_read(dev, reg, buff, len)) {
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -55,7 +55,7 @@ static int pfuze100_bind(struct udevice *dev)
regulators_node = dev_read_subnode(dev, "regulators");
if (!ofnode_valid(regulators_node)) {
debug("%s: %s regulators subnode not found!", __func__,
debug("%s: %s regulators subnode not found!\n", __func__,
dev->name);
return -ENXIO;
}

6
drivers/power/pmic/rk8xx.c
View File

@ -29,7 +29,7 @@ static int rk8xx_write(struct udevice *dev, uint reg, const uint8_t *buff,
ret = dm_i2c_write(dev, reg, buff, len);
if (ret) {
debug("write error to device: %p register: %#x!", dev, reg);
debug("write error to device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -42,7 +42,7 @@ static int rk8xx_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
ret = dm_i2c_read(dev, reg, buff, len);
if (ret) {
debug("read error from device: %p register: %#x!", dev, reg);
debug("read error from device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -57,7 +57,7 @@ static int rk8xx_bind(struct udevice *dev)
regulators_node = dev_read_subnode(dev, "regulators");
if (!ofnode_valid(regulators_node)) {
debug("%s: %s regulators subnode not found!", __func__,
debug("%s: %s regulators subnode not found!\n", __func__,
dev->name);
return -ENXIO;
}

4
drivers/power/pmic/rn5t567.c
View File

@ -24,7 +24,7 @@ static int rn5t567_write(struct udevice *dev, uint reg, const uint8_t *buff,
ret = dm_i2c_write(dev, reg, buff, len);
if (ret) {
debug("write error to device: %p register: %#x!", dev, reg);
debug("write error to device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -37,7 +37,7 @@ static int rn5t567_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
ret = dm_i2c_read(dev, reg, buff, len);
if (ret) {
debug("read error from device: %p register: %#x!", dev, reg);
debug("read error from device: %p register: %#x!\n", dev, reg);
return ret;
}

8
drivers/power/pmic/s2mps11.c
View File

@ -30,7 +30,7 @@ static int s2mps11_write(struct udevice *dev, uint reg, const uint8_t *buff,
ret = dm_i2c_write(dev, reg, buff, len);
if (ret)
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -41,7 +41,7 @@ static int s2mps11_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
ret = dm_i2c_read(dev, reg, buff, len);
if (ret)
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return ret;
}
@ -53,8 +53,8 @@ static int s2mps11_probe(struct udevice *dev)
regulators_node = dev_read_subnode(dev, "voltage-regulators");
if (!ofnode_valid(regulators_node)) {
debug("%s: %s regulators subnode not found!", __func__,
dev->name);
debug("%s: %s regulators subnode not found!\n", __func__,
dev->name);
return -ENXIO;
}

6
drivers/power/pmic/s5m8767.c
View File

@ -27,7 +27,7 @@ static int s5m8767_write(struct udevice *dev, uint reg, const uint8_t *buff,
int len)
{
if (dm_i2c_write(dev, reg, buff, len)) {
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -37,7 +37,7 @@ static int s5m8767_write(struct udevice *dev, uint reg, const uint8_t *buff,
static int s5m8767_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
{
if (dm_i2c_read(dev, reg, buff, len)) {
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -56,7 +56,7 @@ static int s5m8767_bind(struct udevice *dev)
node = dev_read_subnode(dev, "regulators");
if (!ofnode_valid(node)) {
debug("%s: %s regulators subnode not found!", __func__,
debug("%s: %s regulators subnode not found!\n", __func__,
dev->name);
return -ENXIO;
}

4
drivers/power/pmic/sandbox.c
View File

@ -28,7 +28,7 @@ static int sandbox_pmic_write(struct udevice *dev, uint reg,
const uint8_t *buff, int len)
{
if (dm_i2c_write(dev, reg, buff, len)) {
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -39,7 +39,7 @@ static int sandbox_pmic_read(struct udevice *dev, uint reg,
uint8_t *buff, int len)
{
if (dm_i2c_read(dev, reg, buff, len)) {
pr_err("read error from device: %p register: %#x!", dev, reg);
pr_err("read error from device: %p register: %#x!\n", dev, reg);
return -EIO;
}

2
drivers/power/pmic/stpmu1.c
View File

@ -61,7 +61,7 @@ static int stpmu1_bind(struct udevice *dev)
regulators_node = dev_read_subnode(dev, "regulators");
if (!ofnode_valid(regulators_node)) {
dev_dbg(dev, "regulators subnode not found!");
dev_dbg(dev, "regulators subnode not found!\n");
return -ENXIO;
}
dev_dbg(dev, "found regulators subnode\n");

8
drivers/power/pmic/tps65090.c
View File

@ -26,7 +26,7 @@ static int tps65090_write(struct udevice *dev, uint reg, const uint8_t *buff,
int len)
{
if (dm_i2c_write(dev, reg, buff, len)) {
pr_err("write error to device: %p register: %#x!", dev, reg);
pr_err("write error to device: %p register: %#x!\n", dev, reg);
return -EIO;
}
@ -39,8 +39,8 @@ static int tps65090_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
ret = dm_i2c_read(dev, reg, buff, len);
if (ret) {
pr_err("read error %d from device: %p register: %#x!", ret, dev,
reg);
pr_err("read error %d from device: %p register: %#x!\n", ret,
dev, reg);
return -EIO;
}
@ -54,7 +54,7 @@ static int tps65090_bind(struct udevice *dev)
regulators_node = dev_read_subnode(dev, "regulators");
if (!ofnode_valid(regulators_node)) {
debug("%s: %s regulators subnode not found!", __func__,
debug("%s: %s regulators subnode not found!\n", __func__,
dev->name);
return -ENXIO;
}