leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tools: Check arguments in fit_check_sign/fit_info

Browse Source 
These tools crash if no arguments are provided. Add checks to avoid this.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Heiko Schocher <hs@denx.de>
This commit is contained in:
Simon Glass 2014-06-12 07:24:44 -06:00 committed by Tom Rini
parent d18926af30
commit ba923cab00
2 changed files with 21 additions and 0 deletions

9
tools/fit_check_sign.c
View File

@ -62,6 +62,15 @@ int main(int argc, char **argv)
break;
}
if (!fdtfile) {
fprintf(stderr, "%s: Missing fdt file\n", *argv);
usage(*argv);
}
if (!keyfile) {
fprintf(stderr, "%s: Missing key file\n", *argv);
usage(*argv);
}
ffd = mmap_fdt(cmdname, fdtfile, 0, &fit_blob, &fsbuf, false);
if (ffd < 0)
return EXIT_FAILURE;

12
tools/fit_info.c
View File

@ -68,6 +68,18 @@ int main(int argc, char **argv)
break;
}
if (!fdtfile) {
fprintf(stderr, "%s: Missing fdt file\n", *argv);
usage(*argv);
}
if (!nodename) {
fprintf(stderr, "%s: Missing node name\n", *argv);
usage(*argv);
}
if (!propertyname) {
fprintf(stderr, "%s: Missing property name\n", *argv);
usage(*argv);
}
ffd = mmap_fdt(cmdname, fdtfile, 0, &fit_blob, &fsbuf, false);
if (ffd < 0) {