leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

env: mmc: Correct partition comparison in mmc_offset_try_partition

Browse Source 
The function mmc_offset_try_partition searches the MMC partition for
locating environment data, by comparing the partition names with config
"u-boot,mmc-env-parition". However, it only compares the first word-size
bytes (size of 'const char *'), which may make the function to find
unintended partition.

Correct the function not to partially compare the partition name with
config "u-boot,mmc-env-partition".

Fixes: c9e87ba665 ("env: Save environment at the end of an MMC partition")
Signed-off-by: Hoyeonjiki Kim <jigi.kim@gmail.com>
Reviewed-by: Wolfgang Denk <wd@denx.de>
This commit is contained in:
Hoyeonjiki Kim 2020-11-17 12:32:08 +09:00 committed by Tom Rini
parent e800d715e0
commit 2a0a577aad
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
env/mmc.c vendored
View File

@ -42,7 +42,7 @@ static inline int mmc_offset_try_partition(const char *str, int copy, s64 *val)
if (ret < 0)
return ret;
if (!strncmp((const char *)info.name, str, sizeof(str)))
if (!strncmp((const char *)info.name, str, sizeof(info.name)))
break;
}