linux/drivers/net/can/spi/mcp251xfd
Tom Rix fa7b514d2b can: mcp251xfd: mcp251xfd_register_get_dev_id(): fix return of error value
Clang static analysis reports this issue:

| mcp251xfd-core.c:1813:7: warning: The left operand
|   of '&' is a garbage value
|   FIELD_GET(MCP251XFD_REG_DEVID_ID_MASK, dev_id),
|   ^                                      ~~~~~~

dev_id is set in a successful call to mcp251xfd_register_get_dev_id().
Though the status of calls made by mcp251xfd_register_get_dev_id() are
checked and handled, their status' are not returned. So return err.

Fixes: 55e5b97f00 ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Link: https://lore.kernel.org/all/20220319153128.2164120-1-trix@redhat.com
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2022-03-31 09:55:11 +02:00
..
Kconfig can: mcp251xfd: add dev coredump support 2021-03-30 11:14:49 +02:00
Makefile can: mcp251xfd: ethtool: add support 2022-03-13 09:45:35 +01:00
mcp251xfd-chip-fifo.c can: mcp251xfd: introduce struct mcp251xfd_tx_ring::nr and ::fifo_nr and make use of it 2022-02-24 08:46:59 +01:00
mcp251xfd-core.c can: mcp251xfd: mcp251xfd_register_get_dev_id(): fix return of error value 2022-03-31 09:55:11 +02:00
mcp251xfd-crc16.c can: mcp251xfd: rename all remaining occurrence to mcp251xfd 2020-09-30 21:55:28 +02:00
mcp251xfd-dump.c can: mcp251xfd: introduce struct mcp251xfd_tx_ring::nr and ::fifo_nr and make use of it 2022-02-24 08:46:59 +01:00
mcp251xfd-dump.h can: mcp251xfd: add dev coredump support 2021-03-30 11:14:49 +02:00
mcp251xfd-ethtool.c can: mcp251xfd: add TX IRQ coalescing ethtool support 2022-03-13 09:45:36 +01:00
mcp251xfd-ram.c can: mcp251xfd: ram: coalescing support 2022-03-13 09:45:35 +01:00
mcp251xfd-ram.h can: mcp251xfd: ram: coalescing support 2022-03-13 09:45:35 +01:00
mcp251xfd-regmap.c can: mcp251xfd: introduce struct mcp251xfd_tx_ring::nr and ::fifo_nr and make use of it 2022-02-24 08:46:59 +01:00
mcp251xfd-ring.c can: mcp251xfd: add TX IRQ coalescing ethtool support 2022-03-13 09:45:36 +01:00
mcp251xfd-rx.c can: mcp251xfd: add RX IRQ coalescing support 2022-03-13 09:45:36 +01:00
mcp251xfd-tef.c can: mcp251xfd: add TX IRQ coalescing support 2022-03-13 09:45:36 +01:00
mcp251xfd-timestamp.c can: mcp251xfd: mark some instances of struct mcp251xfd_priv as const 2021-08-19 15:07:03 +02:00
mcp251xfd-tx.c can: mcp251xfd: move TX handling into separate file 2022-01-08 20:17:42 +01:00
mcp251xfd.h can: mcp251xfd: ring: increase number of RX-FIFOs to 3 and increase max TX-FIFO depth to 16 2022-03-13 09:45:36 +01:00