leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
75659c6fb5
linux/drivers/net/can/spi
History
Tom Rix fa7b514d2b can: mcp251xfd: mcp251xfd_register_get_dev_id(): fix return of error value 
Clang static analysis reports this issue:

| mcp251xfd-core.c:1813:7: warning: The left operand
|   of '&' is a garbage value
|   FIELD_GET(MCP251XFD_REG_DEVID_ID_MASK, dev_id),
|   ^                                      ~~~~~~

dev_id is set in a successful call to mcp251xfd_register_get_dev_id().
Though the status of calls made by mcp251xfd_register_get_dev_id() are
checked and handled, their status' are not returned. So return err.

Fixes: 55e5b97f00 ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Link: https://lore.kernel.org/all/20220319153128.2164120-1-trix@redhat.com
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2022-03-31 09:55:11 +02:00
..
mcp251xfd can: mcp251xfd: mcp251xfd_register_get_dev_id(): fix return of error value 2022-03-31 09:55:11 +02:00
hi311x.c can: Use netif_rx(). 2022-03-06 11:05:31 +00:00
Kconfig can: mcp251xfd: rename driver files and subdir to mcp251xfd 2020-09-30 21:54:30 +02:00
Makefile can: mcp251xfd: rename driver files and subdir to mcp251xfd 2020-09-30 21:54:30 +02:00
mcp251x.c can: Use netif_rx(). 2022-03-06 11:05:31 +00:00