Shawn Guo 4ee107c514 clk: qcom: smd-rpm: Fix MSM8936 RPM_SMD_PCNOC_A_CLK ... Commit a0384ecfe2 ("clk: qcom: smd-rpm: De-duplicate identical entries") introduces the following regression on MSM8936/MSM8939, as RPM_SMD_PCNOC_A_CLK gets pointed to pcnoc_clk by mistake. Fix it by correcting the clock to pcnoc_a_clk. [ 1.307363] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 1.313593] Mem abort info: [ 1.322512] ESR = 0x96000004 [ 1.325132] EC = 0x25: DABT (current EL), IL = 32 bits [ 1.338872] SET = 0, FnV = 0 [ 1.355483] EA = 0, S1PTW = 0 [ 1.368702] FSC = 0x04: level 0 translation fault [ 1.383294] Data abort info: [ 1.398292] ISV = 0, ISS = 0x00000004 [ 1.398297] CM = 0, WnR = 0 [ 1.398301] [0000000000000000] user address but active_mm is swapper [ 1.404193] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 1.420596] Modules linked in: [ 1.420604] CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 5.14.0-rc3+ #198 [ 1.441010] pc : __clk_register+0x48/0x780 [ 1.446045] lr : __clk_register+0x3c/0x780 [ 1.449953] sp : ffff800010063440 [ 1.454031] x29: ffff800010063440 x28: 0000000000000004 x27: 0000000000000066 [ 1.457423] x26: 0000000000000001 x25: 000000007fffffff x24: ffff800010f9f388 [ 1.464540] x23: ffff00007fc12a90 x22: ffff0000034b2010 x21: 0000000000000000 [ 1.471658] x20: ffff800010f9fff8 x19: ffff00000152a700 x18: 0000000000000001 [ 1.478778] x17: ffff00007fbd40c8 x16: 0000000000000460 x15: 0000000000000465 [ 1.485895] x14: ffffffffffffffff x13: 746e756f635f7265 x12: 696669746f6e5f6b [ 1.493013] x11: 0000000000000006 x10: 0000000000000000 x9 : 0000000000000000 [ 1.500131] x8 : ffff00000152a800 x7 : 0000000000000000 x6 : 000000000000003f [ 1.507249] x5 : 0000000000000040 x4 : 0000000000000000 x3 : 0000000000000004 [ 1.514367] x2 : 0000000000000000 x1 : 0000000000000cc0 x0 : ffff00000152a700 [ 1.521486] Call trace: [ 1.528598] __clk_register+0x48/0x780 [ 1.530855] clk_hw_register+0x20/0x60 [ 1.534674] devm_clk_hw_register+0x50/0xa8 [ 1.538408] rpm_smd_clk_probe+0x1a4/0x260 [ 1.542488] platform_probe+0x68/0xd8 [ 1.546653] really_probe+0x140/0x2f8 [ 1.550386] __driver_probe_device+0x78/0xe0 [ 1.554033] driver_probe_device+0x80/0x110 [ 1.558373] __device_attach_driver+0x90/0xe0 [ 1.562280] bus_for_each_drv+0x78/0xc8 [ 1.566793] __device_attach+0xf0/0x150 [ 1.570438] device_initial_probe+0x14/0x20 [ 1.574259] bus_probe_device+0x9c/0xa8 [ 1.578425] device_add+0x378/0x870 [ 1.582243] of_device_add+0x44/0x60 [ 1.585716] of_platform_device_create_pdata+0xc0/0x110 [ 1.589538] of_platform_bus_create+0x17c/0x388 [ 1.594485] of_platform_populate+0x50/0xf0 [ 1.598998] qcom_smd_rpm_probe+0xd4/0x128 [ 1.603164] rpmsg_dev_probe+0xbc/0x1a8 [ 1.607330] really_probe+0x140/0x2f8 [ 1.611063] __driver_probe_device+0x78/0xe0 [ 1.614883] driver_probe_device+0x80/0x110 [ 1.619224] __device_attach_driver+0x90/0xe0 [ 1.623131] bus_for_each_drv+0x78/0xc8 [ 1.627643] __device_attach+0xf0/0x150 [ 1.631289] device_initial_probe+0x14/0x20 [ 1.635109] bus_probe_device+0x9c/0xa8 [ 1.639275] device_add+0x378/0x870 [ 1.643095] device_register+0x20/0x30 [ 1.646567] rpmsg_register_device+0x54/0x90 [ 1.650387] qcom_channel_state_worker+0x168/0x288 [ 1.654814] process_one_work+0x1a0/0x328 [ 1.659415] worker_thread+0x4c/0x420 [ 1.663494] kthread+0x150/0x160 [ 1.667138] ret_from_fork+0x10/0x18 [ 1.670442] Code: 97f56b92 b40034a0 aa0003f3 52819801 (f94002a0) [ 1.674004] ---[ end trace 412fa6f47384cdfe ]--- Fixes: a0384ecfe2 ("clk: qcom: smd-rpm: De-duplicate identical entries") Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Link: https://lore.kernel.org/r/20210727092613.23056-1-shawn.guo@linaro.org Signed-off-by: Stephen Boyd <sboyd@kernel.org>		2021-07-27 11:14:19 -07:00
..
a7-pll.c	clk: qcom: a7-pll: Add missing MODULE_DEVICE_TABLE	2021-04-09 11:20:52 -07:00
a53-pll.c	clk: qcom: a53-pll: Add missing MODULE_DEVICE_TABLE	2021-04-09 11:20:53 -07:00
apcs-msm8916.c	clk: qcom: apcs-msm8916: use clk_parent_data to specify the parent	2020-01-04 23:15:47 -08:00
apcs-sdx55.c	clk: qcom: cleanup some dev_err_probe() calls	2021-06-01 16:34:02 -07:00
apss-ipq6018.c	clk: qcom: Fix return value check in apss_ipq6018_probe()	2020-06-29 14:15:34 -07:00
apss-ipq-pll.c	clk: qcom: apss-ipq-pll: Add missing MODULE_DEVICE_TABLE	2021-04-09 11:20:53 -07:00
camcc-sc7180.c	clk: qcom: camcc: Update the clock ops for the SC7180	2021-03-29 14:08:32 -07:00
camcc-sdm845.c
camcc-sm8250.c	clk: qcom: Add camera clock controller driver for SM8250	2021-06-27 17:19:22 -07:00
clk-alpha-pll.c	clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare	2021-06-27 19:34:31 -07:00
clk-alpha-pll.h	clk: qcom: clk-alpha-pll: add support for zonda pll	2021-06-27 17:12:55 -07:00
clk-branch.c
clk-branch.h
clk-cpu-8996.c	clk: qcom: msm8996: Make symbol 'cpu_msm8996_clks' static	2020-07-20 17:40:18 -07:00
clk-hfpll.c	clk: let init callback return an error code	2019-12-23 18:53:13 -08:00
clk-hfpll.h
clk-krait.c
clk-krait.h
clk-pll.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
clk-pll.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
clk-rcg2.c	clk: qcom: clk-rcg2: Add support for duty-cycle for RCG	2021-05-25 20:36:21 -07:00
clk-rcg.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
clk-rcg.h	clk: qcom: rcg2: Stop hardcoding gfx3d pingpong parent numbers	2021-02-14 12:56:54 -08:00
clk-regmap-divider.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
clk-regmap-divider.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
clk-regmap-mux-div.c
clk-regmap-mux-div.h
clk-regmap-mux.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
clk-regmap-mux.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
clk-regmap.c	clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param	2021-02-10 19:42:51 -08:00
clk-regmap.h	clk: define to_clk_regmap() as inline function	2020-10-28 16:34:44 -07:00
clk-rpm.c	clk: qcom: clk-rpm: Remove a bunch of superfluous code	2021-02-11 11:56:06 -08:00
clk-rpmh.c	clk: qcom: rpmh: add support for SDX55 rpmh IPA clock	2021-04-12 17:55:22 -07:00
clk-smd-rpm.c	clk: qcom: smd-rpm: Fix MSM8936 RPM_SMD_PCNOC_A_CLK	2021-07-27 11:14:19 -07:00
clk-spmi-pmic-div.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284	2019-06-05 17:36:37 +02:00
common.c	clk: qcom: Allow constant ratio freq tables for rcg	2019-11-07 13:43:19 -08:00
common.h	clk: qcom: define probe by index API as common API	2019-08-08 08:20:01 -07:00
dispcc-sc7180.c	clk: qcom: dispcc-sc7180: use parent_hws where possible	2021-04-07 17:22:53 -07:00
dispcc-sdm845.c	clk: qcom: dispcc-sdm845: get rid of the test clock	2021-04-07 17:22:53 -07:00
dispcc-sm8250.c	clk: qcom: dispcc-sm8250: Add EDP clocks	2021-06-02 00:35:29 -07:00
gcc-apq8084.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
gcc-ipq806x.c	ipq806x: gcc: add support for child probe	2020-07-21 00:10:21 -07:00
gcc-ipq4019.c	clk: qcom: gcc-ipq4019: Remove unused variable 'ret'	2021-02-11 11:56:05 -08:00
gcc-ipq6018.c	clk: qcom: Add ipq6018 Global Clock Controller support	2020-01-09 12:42:55 -08:00
gcc-ipq8074.c	clk: qcom: ipq8074: make pcie0_rchng_clk_src static	2020-09-22 11:34:33 -07:00
gcc-mdm9607.c	clk/qcom: Remove unused variables	2021-06-27 17:04:48 -07:00
gcc-mdm9615.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
gcc-msm8660.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
gcc-msm8916.c	clk: qcom: msm8916: Fix the address location of pll->config_reg	2020-04-21 19:45:18 -07:00
gcc-msm8939.c	clk: qcom: gcc-msm8939: remove defined but not used variables	2020-09-22 11:50:23 -07:00
gcc-msm8960.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
gcc-msm8974.c	clk: qcom: gcc: Add support for Global Clock controller found on MSM8226	2021-06-27 17:00:50 -07:00
gcc-msm8994.c	clk: qcom: gcc-msm8994: Add missing clocks, resets and GDSCs	2020-10-13 18:04:36 -07:00
gcc-msm8996.c	clk: qcom: gcc-msm8996: Fix parent for CLKREF clocks	2020-01-06 08:55:28 -08:00
gcc-msm8998.c	clk: qcom: gcc-msm8998: Fix Alpha PLL type for all GPLLs	2021-02-08 10:17:49 -08:00
gcc-qcs404.c	clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency	2019-12-18 22:07:52 -08:00
gcc-sc7180.c	clk: qcom: gcc-sc7180: use ARRAY_SIZE instead of specifying num_parents	2021-04-07 17:25:50 -07:00
gcc-sc7280.c	clk: qcom: gcc: Add support for a new frequency for SC7280	2021-06-27 16:46:11 -07:00
gcc-sc8180x.c	clk: qcom: gcc-sc8180x: use ARRAY_SIZE instead of specifying num_parents	2021-04-07 17:25:52 -07:00
gcc-sdm660.c	clk: qcom: gcc-sdm660: Mark GPU CFG AHB clock as critical	2021-02-14 12:56:54 -08:00
gcc-sdm845.c	clk: qcom: gcc-sdm845: get rid of the test clock	2021-04-09 12:01:22 -07:00
gcc-sdx55.c	clk: qcom: gcc-sdx55: use parent_hws where possible	2021-04-07 17:22:54 -07:00
gcc-sm6125.c	clk: qcom: Add SM6125 (TRINKET) GCC driver	2021-06-27 16:53:29 -07:00
gcc-sm8150.c	clk: qcom: gcc-sm8150: use ARRAY_SIZE instead of specifying num_parents	2021-04-07 17:25:52 -07:00
gcc-sm8250.c	clk: qcom: gcc-sm8250: use ARRAY_SIZE instead of specifying num_parents	2021-04-07 17:25:52 -07:00
gcc-sm8350.c	clk: qcom: gcc-sm8350: use ARRAY_SIZE instead of specifying num_parents	2021-04-07 17:25:53 -07:00
gdsc.c	clk: qcom: gdsc: Implement NO_RET_PERIPH flag	2021-02-14 12:56:54 -08:00
gdsc.h	clk: qcom: gdsc: Implement NO_RET_PERIPH flag	2021-02-14 12:56:54 -08:00
gpucc-msm8998.c	clk: qcom: gpucc-msm8998: Allow fabia gpupll0 rate setting	2021-02-14 12:56:54 -08:00
gpucc-sc7180.c	clk: qcom: gpucc-sc7180: drop unused enum entries	2021-04-07 17:22:51 -07:00
gpucc-sdm660.c	clk: qcom: Add SDM660 GPU Clock Controller (GPUCC) driver	2021-02-14 12:56:54 -08:00
gpucc-sdm845.c	clk: qcom: gpucc-sdm845: get rid of the test clock	2021-04-07 17:22:53 -07:00
gpucc-sm8150.c	clk: qcom: gpucc-sm8150: use parent_hws where possible	2021-04-07 17:22:54 -07:00
gpucc-sm8250.c	clk: qcom: gpucc-sm8250: use parent_hws where possible	2021-04-07 17:22:54 -07:00
hfpll.c	clk: qcom: hfpll: use clk_parent_data to specify the parent	2019-12-18 22:07:52 -08:00
Kconfig	clk: qcom: Add camera clock controller driver for SM8250	2021-06-27 17:19:22 -07:00
kpss-xcc.c
krait-cc.c
lcc-ipq806x.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
lcc-mdm9615.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
lcc-msm8960.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
lpass-gfm-sm8250.c	clk: qcom: gfm-mux: fix clk mask	2021-02-08 09:50:46 -08:00
lpasscc-sdm845.c	clk: qcom: define probe by index API as common API	2019-08-08 08:20:01 -07:00
lpasscorecc-sc7180.c	clk: qcom: lpasscc: Introduce pm autosuspend for SC7180	2020-12-10 12:29:21 -08:00
Makefile	clk: qcom: Add camera clock controller driver for SM8250	2021-06-27 17:19:22 -07:00
mmcc-apq8084.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
mmcc-msm8960.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
mmcc-msm8974.c	clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}'	2021-02-11 11:56:06 -08:00
mmcc-msm8996.c	clk: qcom: mmcc-msm8996: Migrate gfx3d clock to clk_rcg2_gfx3d	2021-02-14 12:56:54 -08:00
mmcc-msm8998.c	clk: qcom: mmcc-msm8998: Set bimc_smmu_gdsc always on	2021-02-08 10:24:34 -08:00
mmcc-sdm660.c	clk: qcom: Add SDM660 Multimedia Clock Controller (MMCC) driver	2021-02-14 12:56:54 -08:00
mss-sc7180.c	clk: qcom: Add modem clock controller driver for SC7180	2020-03-20 16:28:05 -07:00
q6sstop-qcs404.c	clk: qcom: Add Q6SSTOP clock controller for QCS404	2019-11-07 13:10:36 -08:00
reset.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
reset.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
turingcc-qcs404.c	clk: qcom: fix QCS404 TuringCC regmap	2019-09-09 09:05:22 -07:00
videocc-sc7180.c	clk: qcom: videocc-sc7180: drop unused enum entries	2021-04-07 17:22:52 -07:00
videocc-sdm845.c	clk: qcom: videocc-sdm845: get rid of the test clock	2021-04-07 17:22:53 -07:00
videocc-sm8150.c	clk: qcom: videocc-sm8150: use parent_hws where possible	2021-04-07 17:22:54 -07:00
videocc-sm8250.c	clk: qcom: videocc-sm8250: use parent_hws where possible	2021-04-07 17:22:54 -07:00