Commit Graph

428049 Commits

Author SHA1 Message Date
Monam Agarwal
9df2b0d40e Staging: crystalhd: Fix different address spaces warning
This patch fixes following sparse warning in crystalhd_lnx.c
WARNING: incorrect type in argument

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 15:16:26 -08:00
Monam Agarwal
6df1a83ba7 Staging: crystalhd: Fix different address spaces warning from sparse in crystalhd_misc.c
This patch fixes following sparse warning in crystalhd_misc.c
WARNING: incorrect type in argument

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 15:16:26 -08:00
Ebru Akagunduz
421343a438 Staging:dgap: Fix "foo * bar" should be "foo *bar" in dgap.h
Fix checkpatch.pl issues with "foo *  bar" should
be "foo *bar" in dgap.h

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 15:04:20 -08:00
Ebru Akagunduz
857eef411c Staging:dgap: Fix open brace '{' following struct go on the same line in dgap.h
Fix checkpatch.pl issues with open brace '{'
following struct go on the same line in dgap.h

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 15:04:20 -08:00
Ebru Akagunduz
1cfe98f523 Staging:wlags49_h25: Fix sparse warning for static declarations
This patch fixes the Sparse Warnings "symbol
was not declared. Should it be static?"

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:56:14 -08:00
Monam Agarwal
913a3449b4 Staging: wlags49_h2: Fix incorrect type in assignment in wl_wext.c
This patch fixes following sparse warnings:
drivers/staging/wlags49_h2/wl_wext.c:3357:28: warning: incorrect type in assignment (different address spaces)
drivers/staging/wlags49_h2/wl_wext.c:3357:28:    expected void [noderef] <asn:1>*[addressable] [assigned] pointer
drivers/staging/wlags49_h2/wl_wext.c:3357:28:    got void *<noident>
drivers/staging/wlags49_h2/wl_wext.c:3422:47: warning: incorrect type in assignment (different address spaces)
drivers/staging/wlags49_h2/wl_wext.c:3422:47:    expected void [noderef] <asn:1>*[addressable] [assigned] pointer
drivers/staging/wlags49_h2/wl_wext.c:3422:47:    got char *[usertype] <noident>
drivers/staging/wlags49_h2/wl_wext.c:3781:21: warning: symbol 'wl_priv_args' was not declared. Should it be static?

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:54:15 -08:00
Monam Agarwal
c943d9688f Staging: wlags49_h2: Fix Sparse Warning for Static Declarations in dhf.c
This patch fixes the following sparse warnings:
drivers/staging/wlags49_h2/dhf.c:109:6: warning: symbol 'signature' was not declared. Should it be static?
drivers/staging/wlags49_h2/dhf.c:126:25: warning: symbol 'mfi_sup' was not declared. Should it be static?
drivers/staging/wlags49_h2/dhf.c:127:25: warning: symbol 'cfi_sup' was not declared. Should it be static?
drivers/staging/wlags49_h2/dhf.c:142:17: warning: symbol 'ltv_info' was not declared. Should it be static?
drivers/staging/wlags49_h2/dhf.c:173:1: warning: symbol 'check_comp_fw' was not declared. Should it be static?

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:54:15 -08:00
Monam Agarwal
7dffb414d2 Staging: wlags49_h2: Fix Sparse Warning for Static Declarations in hcf.c
This patch fixes following sparse warnings:
drivers/staging/wlags49_h2/hcf.c:253:26: warning: symbol 'cfg_drv_identity' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:262:24: warning: symbol 'cfg_drv_sup_range' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:274:31: warning: symbol 'cfg_drv_act_ranges_pri' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:291:31: warning: symbol 'cfg_drv_act_ranges_sta' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:336:31: warning: symbol 'cfg_drv_act_ranges_hsi' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:373:24: warning: symbol 'cfg_drv_act_ranges_apf' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:3103:1: warning: symbol 'calc_mic' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:3419:1: warning: symbol 'check_mic' was not declared. Should it be static?

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:54:15 -08:00
Monam Agarwal
2dcee514d8 Staging: wlags49_h2: Fix Remove unused functions in wl_util.c
This patch removes the unused function "percent" from wl_util.c

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:53:33 -08:00
Himangi Saraogi
32666af377 staging:wlags49_h2: Remove unnecessary braces in if statements
This patch fixes the checkpatch warnings:
WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:52:27 -08:00
Himangi Saraogi
777021ea74 staging:wlags49_h2: Remove unnecessary spaces around parentheses
This patch fixes the following checkpatch errors:
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:52:27 -08:00
Himangi Saraogi
b16721b7dc staging:wlags49_h2:fix conditional statement warnings
This patch fixes the following warnings:
WARNING: that open brace { should be on the previous line
WARNING: suspect code indent for conditional statements (16, 16)

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:52:27 -08:00
Himangi Saraogi
425754b27b staging:wlags49_h2:change include path for uaccess.h
This patch fixes the following issue detected by checkpatch.pl.
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:52:27 -08:00
Himangi Saraogi
364e7b8371 staging:wlags49_h2: change comment style
Coding style requires that comments use the standard /* */ style
instead of C99 style. The commented #include statements were also
removed as they are not required.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:52:27 -08:00
Monam Agarwal
5461772769 Staging: wlags49_h2: Fix sparse warnings in sta_h2.c
This patch fixes sparse warnings "Using plain integer as NULL pointer" in
sta_h2.c

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:51:35 -08:00
Monam Agarwal
941060b4a1 Staging: iio/accel: Fix Prefer netdev_warn(netdev, ...then dev_warn(dev, ... then pr_warn(... to printk(KERN_INFO ... in sca3000_ring.c
This patch fixes the following checkpatch.pl warning in sca3000_ring.c
WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:48:47 -08:00
Monam Agarwal
21d9fbcc4f Staging: iio/resolver: Fix prefer pr_warn over pr_warning in ad2s1210.c
This patch fixes following checkpatch.pl warning
WARNING: Prefer pr_warn(... to pr_warning(...

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:48:47 -08:00
Elena Oat
ba5be64678 Staging: rtl8188eu: Fix warning of prefer ether_addr_copy.
This patch fixes the warning of "Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)" in file rtw_cmd.c. Pahole
shows that the addresses are 2-byte aligned.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:47:39 -08:00
Elena Oat
dc29fcae7a Staging: rtl8188eu: Fix warning of suspect code indent.
This patch fixes the warning of "suspect code indent for conditional
statements" in file rtw_cmd.c. I have removed the conditional statements
in two places altogether, as it didn't bring any value.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:47:03 -08:00
Elena Oat
719e897cf1 Staging: rtl8188eu: Fix warning of space prohibited before semicolon.
This patch fixes the warning of "space prohibited before semicolon" in file rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:47:03 -08:00
Elena Oat
440dacdf6c Staging: rtl8188eu: Fix warning of unnecessary parentheses.
This patch fixes the warning of "unnecessary parentheses" in file rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:47:03 -08:00
Elena Oat
cc96a42891 Staging: rtl8188eu: Fix warning of space before tabs.
This patch fixes the warning of "please, no space before tabs" in file
rtw_cmd.c. I have also removed couple of lines of code that was
commented and probably left from the previous version.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:47:03 -08:00
Elena Oat
7c3000c377 Staging: rtl8188eu: Fix warning of spaces at the start of a line.
This patch fixes the warning of "please, no spaces at the start of a
line" in file rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:47:03 -08:00
Elena Oat
8ee6421b6c Staging: rtl8188eu: Fix warning braces {} are not necessary.
This patch fixes the warning of "braces {} are not necessary for single
statement blocks" in file rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:46:31 -08:00
Monam Agarwal
c6b2dcdc8b Staging: rtl8188eu: Fix sparse warning cast to restricted __le16
This patch fixes the following sparse warnings:
drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1627:25: warning: cast to restricted __le16
by changing the annotations in the struct declaration.

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:44:04 -08:00
Elena Oat
29698f1e9d Staging: rtl8188eu: Fix warning of printk should include KERN_.
This patch fixes the warning produced by checkpatch of "printk should
include KERN_ facility level". printk was replaced by netdev_info. While
at it, I have also fixed the line over 80 characters warning.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:44:04 -08:00
Elena Oat
48e7124179 Staging: rtl8188eu: Fix warning of prefer ether_addr_copy().
This patch fixes the warning produced by checkpatch "Prefer
ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)". The address that is copied is a field of
nat25_network_db_entry structure. Definition for this struct is found in
rtw_br_ext.h file. Pahole shows that the addresses are 2-byte aligned.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:44:04 -08:00
Elena Oat
2c05f00f88 Staging: rtl8188eu: Fix warning of braces {} are not necessary.
This patch fixes the warning of "braces {} are not necessary for any arm
of this statement" in file rtw_ioctl_set.c. The braces are removed in
three places.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:44:04 -08:00
Ebru Akagunduz
6fb081577f Staging:rtl8188eu: fix kfree(NULL) is safe this check is probably not required in rtw_ap.c
Fix checkpatch.pl issues with kfree(NULL) is safe this
check is probably not required in rtw_ap.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:42:24 -08:00
Elena Oat
73e183426f Staging: rtl8188eu: Fix warning of kfree check is not required.
This patch fixes the warning produced by checkpatch in the file
rtw_cmd.c "kfree(NULL) is safe this check is probably not required". The
patch fixes it in two places for this file.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:34:12 -08:00
Elena Oat
138050a2d7 Staging: rtl8188eu: Fix warning of no space before tabs.
This patch fixes the warning of "Please, no space before tab" produced
by checkpatch.pl. The modified file: rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:34:12 -08:00
Elena Oat
867892f372 Staging: rtl8188eu: Fix the warning of space before parenthesis.
This patch fixes the warning of "space prohibited between function name
and open parenthesis '('". The modified file: rtw_cmd.c. The patch also
removes some strange spaces that were generated probably by some editor.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 14:34:12 -08:00
Greg Kroah-Hartman
bfe24b9cbe Merge branch 'imx-drm-staging' of git://ftp.arm.linux.org.uk/~rmk/linux-arm into staging-next
Russell writes:

This set of changes reorganises imx-drm's DT bindings by re-using the OF
graph parsing code which was located in drivers/media, removing the
temporary bindings.

The result is that more TODO entries are now removed.  While we're not
quite done with this yet as there's a few straggling updates to imx-ldb
to come, but leaving these out is not detrimental at this point in time
- they are more an enhancement.

However, this pull has the additional complication that we're sharing
seven commits with Mauro's V4L git tree, which move the OF graph parsing
code out of drivers/media into drivers/of.  Philipp's imx-drm changes
depend on these and my previously committed round of imx-drm commits.
Hence, the diffstat below is from a test merge with your tree head
(17b02809cf).

Mauro merged those seven commits earlier today as a git pull, so both
trees will be sharing exactly the same commit IDs.

I've given these changes a spin here on both my Hummingboard and Cubox-i4
(one is iMX6Solo, the other is iMX6Quad based), which includes Xorg using
the DRM device directly, and I find nothing wrong.

The diffstat does look a little scarey - this is because we're having to
update the ARM DT files along with this change, and obviously the
dependency on the OF graph parsing code.
2014-03-07 14:23:34 -08:00
bahar sahin
4504b1bc05 Staging: octeon: Fix coding style
This patch removes unnecessary braces to fix a checkpatch.pl warning.

Signed-off-by: bahar sahin <baharxf@gmail.com>
Reviewed-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:52:23 -08:00
Himangi Saraogi
8a125b0e04 staging:octeon: Replace pr_warning by preferred pr_warn
This patch fixes the checkpatch.pl warning :
Prefer pr_warn(... to pr_warning(...

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:52:23 -08:00
Himangi Saraogi
0da50c69c0 staging:octeon: remove space after opening parentheses
This patch fixes the checkpatch warning : space prohibited after
that open parenthesis '('.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:52:23 -08:00
Ebru Akagunduz
ade6509d1f Staging:wlan-ng: no space before tabs in p80211mgmt.h
Fix checkpatch.pl issues with no space before tabs
in p80211mgmt.h

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:48:03 -08:00
Himangi Saraogi
8cbe56e09c staging:wlan-ng:Fix sparse warning cast to restricted __le16
This patch fixes the following sparse warnings:
drivers/staging/wlan-ng/hfa384x_usb.c:3582:14: warning: cast to
restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:3584:19: warning: cast to
restricted __le16
by changing the annotations in the struct declaration.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:48:03 -08:00
Tugce Sirin
4d8c1d0fdf Staging: wlan-ng: Fix Sparse warning should it be static?
This patch fixes following Sparse warning should it be static? in
staging/wlan-ng.

Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:44:17 -08:00
Monam Agarwal
b66cbef25e Staging: ced1401: Fix removed unused structs
This patch removes an unused struct while at the same time removing checkpatch.pl warning
WARNING: Avoid use of typedef

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:39:56 -08:00
Monam Agarwal
e68f33b881 Staging: ced1401: Fix do not add new typedefs
This patch fixes the following checkpatch.pl issues in ced_ioctl.h
WARNING: do not add new typedefs

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:39:56 -08:00
Monam Agarwal
7e41d9c341 Staging: gs_gpgaboot: Fix Bad function definition in io.c
This patch fixes the following checkpatch.pl issues in io.c
WARNING: Bad function definition

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:39:56 -08:00
Monam Agarwal
206654728b Staging: dgnc: Fix struct file_operations should normally be const
This patch fixes following checkpatch.pl warning:
WARNING:struct file_operations should normally be const

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:36:38 -08:00
Kristina Martšenko
eb55b5b480 staging: sbe-2t3e3: remove t3e3_resp_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_resp_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/ctrl.h:123: WARNING: do not add new typedefs

Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:32:48 -08:00
Kristina Martšenko
c6a297bcb1 staging: sbe-2t3e3: remove t3e3_stats_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_stats_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/ctrl.h:107: WARNING: do not add new typedefs

Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:32:48 -08:00
Kristina Martšenko
154d2b8cb6 staging: sbe-2t3e3: remove t3e3_param_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_param_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/ctrl.h:87: WARNING: do not add new typedefs

Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:32:48 -08:00
Kristina Martšenko
844a18cec6 staging: sbe-2t3e3: remove t3e3_tx_desc_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_tx_desc_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/2t3e3.h:651: WARNING: do not add new typedefs

Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:32:48 -08:00
Kristina Martšenko
692d79e179 staging: sbe-2t3e3: remove t3e3_rx_desc_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_rx_desc_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/2t3e3.h:616: WARNING: do not add new typedefs

Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:32:47 -08:00
Elena Oat
10a0e2e22f Staging: sbe-2t3e3: Fix the error of (foo*) should be (foo *).
This patch fixes an error in 2t3e3.h that (foo*) should be (foo *).

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:29:25 -08:00
Himangi Saraogi
f6250023a0 staging:sbe-2t3e3: remove assignment in if condition
This patch removes the assignment in an if condition to do away with
the checkpatch warning :'do not use assignment in if condition'.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07 13:29:25 -08:00