forked from Minki/linux
drm/scheduler: Set sched->thread to NULL on failure
In cases where the scheduler instance is used as a base object of another driver object, it's not clear if the driver can call scheduler cleanup on the fail path. So, Set the sched->thread to NULL, so that the driver can safely call drm_sched_fini() during cleanup. Signed-off-by: Sharat Masetty <smasetty@codeaurora.org> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
parent
8288b2e5ae
commit
9afd07566b
@ -612,7 +612,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,
|
||||
long timeout,
|
||||
const char *name)
|
||||
{
|
||||
int i;
|
||||
int i, ret;
|
||||
sched->ops = ops;
|
||||
sched->hw_submission_limit = hw_submission;
|
||||
sched->name = name;
|
||||
@ -633,8 +633,10 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,
|
||||
/* Each scheduler will run on a seperate kernel thread */
|
||||
sched->thread = kthread_run(drm_sched_main, sched, sched->name);
|
||||
if (IS_ERR(sched->thread)) {
|
||||
ret = PTR_ERR(sched->thread);
|
||||
sched->thread = NULL;
|
||||
DRM_ERROR("Failed to create scheduler for %s.\n", name);
|
||||
return PTR_ERR(sched->thread);
|
||||
return ret;
|
||||
}
|
||||
|
||||
sched->ready = true;
|
||||
|
Loading…
Reference in New Issue
Block a user