leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

selftests/powerpc: Remove Power9 copy_unaligned test

Browse Source 
This is a test of the ISA 3.0 "copy" instruction. That instruction has
an L field, which if set to 1 specifies that "the instruction
identifies the beginning of a move group" (pp 858). That's also
referred to as "copy first" vs "copy".

In ISA 3.0B the copy instruction does not have an L field, and the
corresponding bit in the instruction must be set to 1.

This test is generating a "copy" instruction, not a "copy first", and
so on Power9 (which implements 3.0B), this results in an illegal
instruction.

So just drop the test entirely. We still have copy_first_unaligned to
test the "copy first" behaviour.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Michael Ellerman 2018-07-11 17:10:15 +10:00
parent ec9336396a
commit 83039f22ba
3 changed files with 1 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/testing/selftests/powerpc/alignment/.gitignore vendored
View File

@ -1,4 +1,3 @@
copy_unaligned
copy_first_unaligned
paste_unaligned
paste_last_unaligned

2
tools/testing/selftests/powerpc/alignment/Makefile
View File

@ -1,4 +1,4 @@
TEST_GEN_PROGS := copy_unaligned copy_first_unaligned paste_unaligned \
TEST_GEN_PROGS := copy_first_unaligned paste_unaligned \
paste_last_unaligned alignment_handler
include ../../lib.mk

41
tools/testing/selftests/powerpc/alignment/copy_unaligned.c
View File

@ -1,41 +0,0 @@
/*
* Copyright 2016, Chris Smart, IBM Corporation.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version
* 2 of the License, or (at your option) any later version.
*
* Calls to copy which are not 128-byte aligned should be caught
* and sent a SIGBUS.
*
*/
#include <string.h>
#include <unistd.h>
#include "utils.h"
#include "instructions.h"
#include "copy_paste_unaligned_common.h"
unsigned int expected_instruction = PPC_INST_COPY;
unsigned int instruction_mask = 0xfc0007fe;
int test_copy_unaligned(void)
{
/* Only run this test on a P9 or later */
SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_00));
/* Register our signal handler with SIGBUS */
setup_signal_handler();
/* +1 makes buf unaligned */
copy(cacheline_buf+1);
/* We should not get here */
return 1;
}
int main(int argc, char *argv[])
{
return test_harness(test_copy_unaligned, "test_copy_unaligned");
}