mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 21:33:00 +00:00
cd6eb534fb
sun6i-a31-apb0-gates supports using clock-indices for holes between individual gates. However, the driver passes the number of gates registered in clk_data->clk_num, which of_clk_src_onecell_get uses to recognize the range of valid indices a consumer can use. This patch makes the driver pass the maximum gate index + 1, so of_clk_src_onecell_get does not complain about indices greater than gates registered. This was tested on the A23 SoC, which has a similar APB0 clock, but has holes for gates to removed IP blocks. Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
104 lines
2.5 KiB
C
104 lines
2.5 KiB
C
/*
|
|
* Copyright (C) 2014 Free Electrons
|
|
*
|
|
* License Terms: GNU General Public License v2
|
|
* Author: Boris BREZILLON <boris.brezillon@free-electrons.com>
|
|
*
|
|
* Allwinner A31 APB0 clock gates driver
|
|
*
|
|
*/
|
|
|
|
#include <linux/clk-provider.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#define SUN6I_APB0_GATES_MAX_SIZE 32
|
|
|
|
static int sun6i_a31_apb0_gates_clk_probe(struct platform_device *pdev)
|
|
{
|
|
struct device_node *np = pdev->dev.of_node;
|
|
struct clk_onecell_data *clk_data;
|
|
const char *clk_parent;
|
|
const char *clk_name;
|
|
struct resource *r;
|
|
void __iomem *reg;
|
|
int gate_id;
|
|
int ngates;
|
|
int gate_max = 0;
|
|
int i;
|
|
|
|
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
reg = devm_ioremap_resource(&pdev->dev, r);
|
|
if (!reg)
|
|
return PTR_ERR(reg);
|
|
|
|
clk_parent = of_clk_get_parent_name(np, 0);
|
|
if (!clk_parent)
|
|
return -EINVAL;
|
|
|
|
ngates = of_property_count_strings(np, "clock-output-names");
|
|
if (ngates < 0)
|
|
return ngates;
|
|
|
|
if (!ngates || ngates > SUN6I_APB0_GATES_MAX_SIZE)
|
|
return -EINVAL;
|
|
|
|
clk_data = devm_kzalloc(&pdev->dev, sizeof(struct clk_onecell_data),
|
|
GFP_KERNEL);
|
|
if (!clk_data)
|
|
return -ENOMEM;
|
|
|
|
clk_data->clks = devm_kzalloc(&pdev->dev,
|
|
SUN6I_APB0_GATES_MAX_SIZE *
|
|
sizeof(struct clk *),
|
|
GFP_KERNEL);
|
|
if (!clk_data->clks)
|
|
return -ENOMEM;
|
|
|
|
for (i = 0; i < ngates; i++) {
|
|
of_property_read_string_index(np, "clock-output-names",
|
|
i, &clk_name);
|
|
|
|
gate_id = i;
|
|
of_property_read_u32_index(np, "clock-indices", i, &gate_id);
|
|
|
|
WARN_ON(gate_id >= SUN6I_APB0_GATES_MAX_SIZE);
|
|
if (gate_id >= SUN6I_APB0_GATES_MAX_SIZE)
|
|
continue;
|
|
|
|
clk_data->clks[gate_id] = clk_register_gate(&pdev->dev,
|
|
clk_name,
|
|
clk_parent, 0,
|
|
reg, gate_id,
|
|
0, NULL);
|
|
WARN_ON(IS_ERR(clk_data->clks[gate_id]));
|
|
|
|
if (gate_id > gate_max)
|
|
gate_max = gate_id;
|
|
}
|
|
|
|
clk_data->clk_num = gate_max + 1;
|
|
|
|
return of_clk_add_provider(np, of_clk_src_onecell_get, clk_data);
|
|
}
|
|
|
|
const struct of_device_id sun6i_a31_apb0_gates_clk_dt_ids[] = {
|
|
{ .compatible = "allwinner,sun6i-a31-apb0-gates-clk" },
|
|
{ /* sentinel */ }
|
|
};
|
|
|
|
static struct platform_driver sun6i_a31_apb0_gates_clk_driver = {
|
|
.driver = {
|
|
.name = "sun6i-a31-apb0-gates-clk",
|
|
.owner = THIS_MODULE,
|
|
.of_match_table = sun6i_a31_apb0_gates_clk_dt_ids,
|
|
},
|
|
.probe = sun6i_a31_apb0_gates_clk_probe,
|
|
};
|
|
module_platform_driver(sun6i_a31_apb0_gates_clk_driver);
|
|
|
|
MODULE_AUTHOR("Boris BREZILLON <boris.brezillon@free-electrons.com>");
|
|
MODULE_DESCRIPTION("Allwinner A31 APB0 gate clocks driver");
|
|
MODULE_LICENSE("GPL v2");
|