Al Viro 88a2f6468d struct fd: representation change ... We want the compiler to see that fdput() on empty instance is a no-op. The emptiness check is that file reference is NULL, while fdput() is "fput() if FDPUT_FPUT is present in flags". The reason why fdput() on empty instance is a no-op is something compiler can't see - it's that we never generate instances with NULL file reference combined with non-zero flags. It's not that hard to deal with - the real primitives behind fdget() et.al. are returning an unsigned long value, unpacked by (inlined) __to_fd() into the current struct file * + int. The lower bits are used to store flags, while the rest encodes the pointer. Linus suggested that keeping this unsigned long around with the extractions done by inlined accessors should generate a sane code and that turns out to be the case. Namely, turning struct fd into a struct-wrapped unsinged long, with fd_empty(f) => unlikely(f.word == 0) fd_file(f) => (struct file *)(f.word & ~3) fdput(f) => if (f.word & 1) fput(fd_file(f)) ends up with compiler doing the right thing. The cost is the patch footprint, of course - we need to switch f.file to fd_file(f) all over the tree, and it's not doable with simple search and replace; there are false positives, etc. Note that the sole member of that structure is an opaque unsigned long - all accesses should be done via wrappers and I don't want to use a name that would invite manual casts to file pointers, etc. The value of that member is equal either to (unsigned long)p | flags, p being an address of some struct file instance, or to 0 for an empty fd. For now the new predicate (fd_empty(f)) has no users; all the existing checks have form (!fd_file(f)). We will convert to fd_empty() use later; here we only define it (and tell the compiler that it's unlikely to return true). This commit only deals with representation change; there will be followups. Reviewed-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>		2024-08-12 22:01:05 -04:00
..
libxfs	xfs: get rid of xfs_ag_resv_rmapbt_alloc	2024-07-04 14:36:13 +05:30
scrub	xfs: convert "skip_discard" to a proper flags bitset	2024-07-02 11:37:01 -07:00
Kconfig	xfs: verify buffer, inode, and dquot items every tx commit	2024-07-02 11:36:54 -07:00
Makefile	xfs: hoist inode flag conversion functions to libxfs	2024-07-02 11:36:55 -07:00
xfs_acl.c	xfs: make attr removal an explicit operation	2024-04-23 07:46:51 -07:00
xfs_acl.h
xfs_aops.c	xfs: xfs_quota_unreserve_blkres can't fail	2024-05-03 11:15:03 +05:30
xfs_aops.h
xfs_attr_inactive.c	xfs: report dir/attr block corruption errors to the health system	2024-02-22 12:32:18 -08:00
xfs_attr_item.c	xfs: fix xfs_init_attr_trans not handling explicit operation codes	2024-05-27 15:55:52 +05:30
xfs_attr_item.h	xfs: create attr log item opcodes and formats for parent pointers	2024-04-23 07:46:57 -07:00
xfs_attr_list.c	xfs: pass the attr value to put_listent when possible	2024-04-23 07:47:00 -07:00
xfs_bio_io.c
xfs_bmap_item.c	xfs: pass the fsbno to xfs_perag_intent_get	2024-07-02 11:37:01 -07:00
xfs_bmap_item.h	xfs: move xfs_bmap_defer_add to xfs_bmap_item.c	2024-02-22 12:44:21 -08:00
xfs_bmap_util.c	xfs: Fix xfs_prepare_shift() range for RT	2024-07-01 09:32:29 +05:30
xfs_bmap_util.h	xfs: fix freeing speculative preallocations for preallocated files	2024-06-26 14:29:17 +05:30
xfs_buf_item_recover.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_buf_item.c	xfs: verify buffer, inode, and dquot items every tx commit	2024-07-02 11:36:54 -07:00
xfs_buf_item.h
xfs_buf_mem.c	xfs: fix dev_t usage in xmbuf tracepoints	2024-03-15 10:30:23 +05:30
xfs_buf_mem.h	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_buf.c	getting rid of bogus set_blocksize() uses, switching it	2024-05-21 08:34:51 -07:00
xfs_buf.h	New code for 6.9:	2024-03-13 13:52:24 -07:00
xfs_dahash_test.c
xfs_dahash_test.h
xfs_dir2_readdir.c	xfs: refactor dir format helpers	2024-04-26 11:21:46 +05:30
xfs_discard.c	xfs: enable FITRIM on the realtime device	2024-07-01 09:32:29 +05:30
xfs_discard.h	xfs: move log discard work to xfs_discard.c	2023-10-04 09:24:02 +11:00
xfs_dquot_item_recover.c	xfs: dquot recovery does not validate the recovered dquot	2023-11-22 23:39:36 +05:30
xfs_dquot_item.c	xfs: verify buffer, inode, and dquot items every tx commit	2024-07-02 11:36:54 -07:00
xfs_dquot_item.h
xfs_dquot.c	xfs: simplify iext overflow checking and upgrade	2024-05-03 11:20:06 +05:30
xfs_dquot.h	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_drain.c	xfs: pass the fsbno to xfs_perag_intent_get	2024-07-02 11:37:01 -07:00
xfs_drain.h	xfs: pass the fsbno to xfs_perag_intent_get	2024-07-02 11:37:01 -07:00
xfs_error.c	xfs: add error injection to test file mapping exchange recovery	2024-04-15 14:54:19 -07:00
xfs_error.h
xfs_exchmaps_item.c	xfs: capture inode generation numbers in the ondisk exchmaps log item	2024-04-15 14:54:24 -07:00
xfs_exchmaps_item.h	xfs: create deferred log items for file mapping exchanges	2024-04-15 14:54:17 -07:00
xfs_exchrange.c	introduce fd_file(), convert all accessors to it.	2024-08-12 22:00:43 -04:00
xfs_exchrange.h	xfs: create deferred log items for file mapping exchanges	2024-04-15 14:54:17 -07:00
xfs_export.c	xfs: add parent pointer ioctls	2024-04-23 07:47:00 -07:00
xfs_export.h	xfs: add parent pointer ioctls	2024-04-23 07:47:00 -07:00
xfs_extent_busy.c	xfs: unwind xfs_extent_busy_clear	2024-04-22 12:53:34 +05:30
xfs_extent_busy.h	xfs: repair free space btrees	2023-12-15 10:03:32 -08:00
xfs_extfree_item.c	xfs: move xfs_extent_free_defer_add to xfs_extfree_item.c	2024-07-02 11:37:03 -07:00
xfs_extfree_item.h	xfs: move xfs_extent_free_defer_add to xfs_extfree_item.c	2024-07-02 11:37:03 -07:00
xfs_file.c	xfs: fold xfs_ilock_for_write_fault into xfs_write_fault	2024-07-01 09:32:29 +05:30
xfs_file.h	xfs: create a new helper to return a file's allocation unit	2024-04-15 14:54:10 -07:00
xfs_filestream.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_filestream.h
xfs_fsmap.c	xfs: refactor realtime inode locking	2024-04-22 18:00:47 +05:30
xfs_fsmap.h
xfs_fsops.c	xfs: split xfs_mod_freecounter	2024-04-22 18:00:47 +05:30
xfs_fsops.h	xfs: split xfs_mod_freecounter	2024-04-22 18:00:47 +05:30
xfs_globals.c	xfs: add debug knobs to control btree bulk load slack factors	2023-12-15 10:03:28 -08:00
xfs_handle.c	struct fd: representation change	2024-08-12 22:01:05 -04:00
xfs_handle.h	xfs: add parent pointer ioctls	2024-04-23 07:47:00 -07:00
xfs_health.c	xfs: report directory tree corruption in the health information	2024-04-23 16:55:17 -07:00
xfs_hooks.c	xfs: allow scrub to hook metadata updates in other writers	2024-02-22 12:30:45 -08:00
xfs_hooks.h	xfs: allow scrub to hook metadata updates in other writers	2024-02-22 12:30:45 -08:00
xfs_icache.c	vfs-6.11.inode	2024-07-15 11:39:44 -07:00
xfs_icache.h	xfs: use per-mount cpumask to track nonempty percpu inodegc lists	2023-09-11 08:39:03 -07:00
xfs_icreate_item.c	xfs: convert kmem_free() for kvmalloc users to kvfree()	2024-02-13 18:07:34 +05:30
xfs_icreate_item.h
xfs_inode_item_recover.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_inode_item.c	xfs: skip flushing log items during push	2024-07-04 12:46:47 +05:30
xfs_inode_item.h
xfs_inode.c	xfs: skip flushing log items during push	2024-07-04 12:46:47 +05:30
xfs_inode.h	xfs: move dirent update hooks to xfs_dir2.c	2024-07-02 11:37:00 -07:00
xfs_ioctl32.c	xfs: move handle ioctl code to xfs_handle.c	2024-04-23 07:47:00 -07:00
xfs_ioctl32.h	arch: Remove Itanium (IA-64) architecture	2023-09-11 08:13:17 +00:00
xfs_ioctl.c	introduce fd_file(), convert all accessors to it.	2024-08-12 22:00:43 -04:00
xfs_ioctl.h	xfs: move handle ioctl code to xfs_handle.c	2024-04-23 07:47:00 -07:00
xfs_iomap.c	xfs: move the dio write relocking out of xfs_ilock_for_iomap	2024-07-01 09:32:29 +05:30
xfs_iomap.h
xfs_iops.c	New code for 6.11:	2024-07-17 12:57:48 -07:00
xfs_iops.h	xfs: declare xfs_file.c symbols in xfs_file.h	2024-04-15 14:54:09 -07:00
xfs_itable.c	xfs: hide private inodes from bulkstat and handle functions	2024-04-15 14:58:48 -07:00
xfs_itable.h
xfs_iunlink_item.c
xfs_iunlink_item.h
xfs_iwalk.c	xfs: Clear W=1 warning in xfs_iwalk_run_callbacks()	2024-05-27 15:54:24 +05:30
xfs_iwalk.h
xfs_linux.h	xfs: hoist project id get/set functions to libxfs	2024-07-02 11:36:56 -07:00
xfs_log_cil.c	xfs: grant heads track byte counts, not LSNs	2024-07-04 12:46:47 +05:30
xfs_log_priv.h	xfs: grant heads track byte counts, not LSNs	2024-07-04 12:46:47 +05:30
xfs_log_recover.c	xfs: grant heads track byte counts, not LSNs	2024-07-04 12:46:47 +05:30
xfs_log.c	xfs: grant heads track byte counts, not LSNs	2024-07-04 12:46:47 +05:30
xfs_log.h	xfs: AIL doesn't need manual pushing	2024-07-04 12:46:46 +05:30
xfs_message.c
xfs_message.h
xfs_mount.c	xfs: use an XFS_OPSTATE_ flag for detecting if logged xattrs are available	2024-04-23 07:46:51 -07:00
xfs_mount.h	xfs: use an XFS_OPSTATE_ flag for detecting if logged xattrs are available	2024-04-23 07:46:51 -07:00
xfs_mru_cache.c	xfs: use GFP_KERNEL in pure transaction contexts	2024-02-13 18:07:35 +05:30
xfs_mru_cache.h
xfs_notify_failure.c	mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind	2023-12-07 14:34:26 +05:30
xfs_pnfs.c
xfs_pnfs.h
xfs_pwork.c
xfs_pwork.h
xfs_qm_bhv.c	xfs: Remove header files which are included more than once	2024-07-01 09:32:29 +05:30
xfs_qm_syscalls.c
xfs_qm.c	xfs: separate the icreate logic around INIT_XATTRS	2024-07-02 11:36:58 -07:00
xfs_qm.h	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_quota.h	xfs: xfs_quota_unreserve_blkres can't fail	2024-05-03 11:15:03 +05:30
xfs_quotaops.c
xfs_refcount_item.c	xfs: move xfs_refcount_update_defer_add to xfs_refcount_item.c	2024-07-02 11:37:07 -07:00
xfs_refcount_item.h	xfs: move xfs_refcount_update_defer_add to xfs_refcount_item.c	2024-07-02 11:37:07 -07:00
xfs_reflink.c	xfs: convert "skip_discard" to a proper flags bitset	2024-07-02 11:37:01 -07:00
xfs_reflink.h	xfs: move inode copy-on-write predicates to xfs_inode.[ch]	2024-07-02 11:36:55 -07:00
xfs_rmap_item.c	xfs: move xfs_rmap_update_defer_add to xfs_rmap_item.c	2024-07-02 11:37:05 -07:00
xfs_rmap_item.h	xfs: move xfs_rmap_update_defer_add to xfs_rmap_item.c	2024-07-02 11:37:05 -07:00
xfs_rtalloc.c	xfs: fix rtalloc rotoring when delalloc is in use	2024-07-09 09:08:28 +05:30
xfs_rtalloc.h	xfs: move xfs_bmap_rtalloc to xfs_rtalloc.c	2023-12-22 11:18:11 +05:30
xfs_stats.c	xfs: define an in-memory btree for storing refcount bag info during repairs	2024-02-22 12:43:40 -08:00
xfs_stats.h	xfs: define an in-memory btree for storing refcount bag info during repairs	2024-02-22 12:43:40 -08:00
xfs_super.c	xfs: add a incompat feature bit for parent pointers	2024-04-23 07:47:01 -07:00
xfs_super.h	xfs: create scaffolding for creating debugfs entries	2023-08-10 07:48:07 -07:00
xfs_symlink.c	xfs: move dirent update hooks to xfs_dir2.c	2024-07-02 11:37:00 -07:00
xfs_symlink.h	xfs: move remote symlink target read function to libxfs	2024-02-22 12:45:17 -08:00
xfs_sysctl.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
xfs_sysctl.h	xfs: add debug knobs to control btree bulk load slack factors	2023-12-15 10:03:28 -08:00
xfs_sysfs.c	xfs: grant heads track byte counts, not LSNs	2024-07-04 12:46:47 +05:30
xfs_sysfs.h
xfs_trace.c	xfs: l_last_sync_lsn is really AIL state	2024-07-04 12:46:46 +05:30
xfs_trace.h	xfs: grant heads track byte counts, not LSNs	2024-07-04 12:46:47 +05:30
xfs_trans_ail.c	xfs: skip flushing log items during push	2024-07-04 12:46:47 +05:30
xfs_trans_buf.c	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_trans_dquot.c	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_trans_priv.h	xfs: l_last_sync_lsn is really AIL state	2024-07-04 12:46:46 +05:30
xfs_trans.c	xfs: move and rename xfs_trans_committed_bulk	2024-07-04 12:46:46 +05:30
xfs_trans.h	xfs: skip flushing log items during push	2024-07-04 12:46:47 +05:30
xfs_xattr.c	xfs: make the reserved block permission flag explicit in xfs_attr_set	2024-04-23 07:47:03 -07:00
xfs_xattr.h	xfs: remove xfs_da_args.attr_flags	2024-04-23 07:46:50 -07:00
xfs.h	xfs: verify buffer, inode, and dquot items every tx commit	2024-07-02 11:36:54 -07:00