mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 13:22:23 +00:00
85b97637bb
cmci_rediscover() used set_cpus_allowed_ptr() to change the current process's running cpu, and migrate itself to the dest cpu. But worker processes are not allowed to be migrated. If current is a worker, the worker will be migrated to another cpu, but the corresponding worker_pool is still on the original cpu. In this case, the following BUG_ON in try_to_wake_up_local() will be triggered: BUG_ON(rq != this_rq()); This will cause the kernel panic. The call trace is like the following: [ 6155.451107] ------------[ cut here ]------------ [ 6155.452019] kernel BUG at kernel/sched/core.c:1654! ...... [ 6155.452019] RIP: 0010:[<ffffffff810add15>] [<ffffffff810add15>] try_to_wake_up_local+0x115/0x130 ...... [ 6155.452019] Call Trace: [ 6155.452019] [<ffffffff8166fc14>] __schedule+0x764/0x880 [ 6155.452019] [<ffffffff81670059>] schedule+0x29/0x70 [ 6155.452019] [<ffffffff8166de65>] schedule_timeout+0x235/0x2d0 [ 6155.452019] [<ffffffff810db57d>] ? mark_held_locks+0x8d/0x140 [ 6155.452019] [<ffffffff810dd463>] ? __lock_release+0x133/0x1a0 [ 6155.452019] [<ffffffff81671c50>] ? _raw_spin_unlock_irq+0x30/0x50 [ 6155.452019] [<ffffffff810db8f5>] ? trace_hardirqs_on_caller+0x105/0x190 [ 6155.452019] [<ffffffff8166fefb>] wait_for_common+0x12b/0x180 [ 6155.452019] [<ffffffff810b0b30>] ? try_to_wake_up+0x2f0/0x2f0 [ 6155.452019] [<ffffffff8167002d>] wait_for_completion+0x1d/0x20 [ 6155.452019] [<ffffffff8110008a>] stop_one_cpu+0x8a/0xc0 [ 6155.452019] [<ffffffff810abd40>] ? __migrate_task+0x1a0/0x1a0 [ 6155.452019] [<ffffffff810a6ab8>] ? complete+0x28/0x60 [ 6155.452019] [<ffffffff810b0fd8>] set_cpus_allowed_ptr+0x128/0x130 [ 6155.452019] [<ffffffff81036785>] cmci_rediscover+0xf5/0x140 [ 6155.452019] [<ffffffff816643c0>] mce_cpu_callback+0x18d/0x19d [ 6155.452019] [<ffffffff81676187>] notifier_call_chain+0x67/0x150 [ 6155.452019] [<ffffffff810a03de>] __raw_notifier_call_chain+0xe/0x10 [ 6155.452019] [<ffffffff81070470>] __cpu_notify+0x20/0x40 [ 6155.452019] [<ffffffff810704a5>] cpu_notify_nofail+0x15/0x30 [ 6155.452019] [<ffffffff81655182>] _cpu_down+0x262/0x2e0 [ 6155.452019] [<ffffffff81655236>] cpu_down+0x36/0x50 [ 6155.452019] [<ffffffff813d3eaa>] acpi_processor_remove+0x50/0x11e [ 6155.452019] [<ffffffff813a6978>] acpi_device_remove+0x90/0xb2 [ 6155.452019] [<ffffffff8143cbec>] __device_release_driver+0x7c/0xf0 [ 6155.452019] [<ffffffff8143cd6f>] device_release_driver+0x2f/0x50 [ 6155.452019] [<ffffffff813a7870>] acpi_bus_remove+0x32/0x6d [ 6155.452019] [<ffffffff813a7932>] acpi_bus_trim+0x87/0xee [ 6155.452019] [<ffffffff813a7a21>] acpi_bus_hot_remove_device+0x88/0x16b [ 6155.452019] [<ffffffff813a33ee>] acpi_os_execute_deferred+0x27/0x34 [ 6155.452019] [<ffffffff81090589>] process_one_work+0x219/0x680 [ 6155.452019] [<ffffffff81090528>] ? process_one_work+0x1b8/0x680 [ 6155.452019] [<ffffffff813a33c7>] ? acpi_os_wait_events_complete+0x23/0x23 [ 6155.452019] [<ffffffff810923be>] worker_thread+0x12e/0x320 [ 6155.452019] [<ffffffff81092290>] ? manage_workers+0x110/0x110 [ 6155.452019] [<ffffffff81098396>] kthread+0xc6/0xd0 [ 6155.452019] [<ffffffff8167c4c4>] kernel_thread_helper+0x4/0x10 [ 6155.452019] [<ffffffff81671f30>] ? retint_restore_args+0x13/0x13 [ 6155.452019] [<ffffffff810982d0>] ? __init_kthread_worker+0x70/0x70 [ 6155.452019] [<ffffffff8167c4c0>] ? gs_change+0x13/0x13 This patch removes the set_cpus_allowed_ptr() call, and put the cmci rediscover jobs onto all the other cpus using system_wq. This could bring some delay for the jobs. Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com> Signed-off-by: Tony Luck <tony.luck@intel.com>
357 lines
8.5 KiB
C
357 lines
8.5 KiB
C
/*
|
|
* Intel specific MCE features.
|
|
* Copyright 2004 Zwane Mwaikambo <zwane@linuxpower.ca>
|
|
* Copyright (C) 2008, 2009 Intel Corporation
|
|
* Author: Andi Kleen
|
|
*/
|
|
|
|
#include <linux/gfp.h>
|
|
#include <linux/init.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/percpu.h>
|
|
#include <linux/sched.h>
|
|
#include <asm/apic.h>
|
|
#include <asm/processor.h>
|
|
#include <asm/msr.h>
|
|
#include <asm/mce.h>
|
|
|
|
#include "mce-internal.h"
|
|
|
|
/*
|
|
* Support for Intel Correct Machine Check Interrupts. This allows
|
|
* the CPU to raise an interrupt when a corrected machine check happened.
|
|
* Normally we pick those up using a regular polling timer.
|
|
* Also supports reliable discovery of shared banks.
|
|
*/
|
|
|
|
static DEFINE_PER_CPU(mce_banks_t, mce_banks_owned);
|
|
|
|
/*
|
|
* cmci_discover_lock protects against parallel discovery attempts
|
|
* which could race against each other.
|
|
*/
|
|
static DEFINE_RAW_SPINLOCK(cmci_discover_lock);
|
|
|
|
#define CMCI_THRESHOLD 1
|
|
#define CMCI_POLL_INTERVAL (30 * HZ)
|
|
#define CMCI_STORM_INTERVAL (1 * HZ)
|
|
#define CMCI_STORM_THRESHOLD 15
|
|
|
|
static DEFINE_PER_CPU(unsigned long, cmci_time_stamp);
|
|
static DEFINE_PER_CPU(unsigned int, cmci_storm_cnt);
|
|
static DEFINE_PER_CPU(unsigned int, cmci_storm_state);
|
|
|
|
enum {
|
|
CMCI_STORM_NONE,
|
|
CMCI_STORM_ACTIVE,
|
|
CMCI_STORM_SUBSIDED,
|
|
};
|
|
|
|
static atomic_t cmci_storm_on_cpus;
|
|
|
|
static int cmci_supported(int *banks)
|
|
{
|
|
u64 cap;
|
|
|
|
if (mce_cmci_disabled || mce_ignore_ce)
|
|
return 0;
|
|
|
|
/*
|
|
* Vendor check is not strictly needed, but the initial
|
|
* initialization is vendor keyed and this
|
|
* makes sure none of the backdoors are entered otherwise.
|
|
*/
|
|
if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
|
|
return 0;
|
|
if (!cpu_has_apic || lapic_get_maxlvt() < 6)
|
|
return 0;
|
|
rdmsrl(MSR_IA32_MCG_CAP, cap);
|
|
*banks = min_t(unsigned, MAX_NR_BANKS, cap & 0xff);
|
|
return !!(cap & MCG_CMCI_P);
|
|
}
|
|
|
|
void mce_intel_cmci_poll(void)
|
|
{
|
|
if (__this_cpu_read(cmci_storm_state) == CMCI_STORM_NONE)
|
|
return;
|
|
machine_check_poll(MCP_TIMESTAMP, &__get_cpu_var(mce_banks_owned));
|
|
}
|
|
|
|
void mce_intel_hcpu_update(unsigned long cpu)
|
|
{
|
|
if (per_cpu(cmci_storm_state, cpu) == CMCI_STORM_ACTIVE)
|
|
atomic_dec(&cmci_storm_on_cpus);
|
|
|
|
per_cpu(cmci_storm_state, cpu) = CMCI_STORM_NONE;
|
|
}
|
|
|
|
unsigned long mce_intel_adjust_timer(unsigned long interval)
|
|
{
|
|
int r;
|
|
|
|
if (interval < CMCI_POLL_INTERVAL)
|
|
return interval;
|
|
|
|
switch (__this_cpu_read(cmci_storm_state)) {
|
|
case CMCI_STORM_ACTIVE:
|
|
/*
|
|
* We switch back to interrupt mode once the poll timer has
|
|
* silenced itself. That means no events recorded and the
|
|
* timer interval is back to our poll interval.
|
|
*/
|
|
__this_cpu_write(cmci_storm_state, CMCI_STORM_SUBSIDED);
|
|
r = atomic_sub_return(1, &cmci_storm_on_cpus);
|
|
if (r == 0)
|
|
pr_notice("CMCI storm subsided: switching to interrupt mode\n");
|
|
/* FALLTHROUGH */
|
|
|
|
case CMCI_STORM_SUBSIDED:
|
|
/*
|
|
* We wait for all cpus to go back to SUBSIDED
|
|
* state. When that happens we switch back to
|
|
* interrupt mode.
|
|
*/
|
|
if (!atomic_read(&cmci_storm_on_cpus)) {
|
|
__this_cpu_write(cmci_storm_state, CMCI_STORM_NONE);
|
|
cmci_reenable();
|
|
cmci_recheck();
|
|
}
|
|
return CMCI_POLL_INTERVAL;
|
|
default:
|
|
/*
|
|
* We have shiny weather. Let the poll do whatever it
|
|
* thinks.
|
|
*/
|
|
return interval;
|
|
}
|
|
}
|
|
|
|
static bool cmci_storm_detect(void)
|
|
{
|
|
unsigned int cnt = __this_cpu_read(cmci_storm_cnt);
|
|
unsigned long ts = __this_cpu_read(cmci_time_stamp);
|
|
unsigned long now = jiffies;
|
|
int r;
|
|
|
|
if (__this_cpu_read(cmci_storm_state) != CMCI_STORM_NONE)
|
|
return true;
|
|
|
|
if (time_before_eq(now, ts + CMCI_STORM_INTERVAL)) {
|
|
cnt++;
|
|
} else {
|
|
cnt = 1;
|
|
__this_cpu_write(cmci_time_stamp, now);
|
|
}
|
|
__this_cpu_write(cmci_storm_cnt, cnt);
|
|
|
|
if (cnt <= CMCI_STORM_THRESHOLD)
|
|
return false;
|
|
|
|
cmci_clear();
|
|
__this_cpu_write(cmci_storm_state, CMCI_STORM_ACTIVE);
|
|
r = atomic_add_return(1, &cmci_storm_on_cpus);
|
|
mce_timer_kick(CMCI_POLL_INTERVAL);
|
|
|
|
if (r == 1)
|
|
pr_notice("CMCI storm detected: switching to poll mode\n");
|
|
return true;
|
|
}
|
|
|
|
/*
|
|
* The interrupt handler. This is called on every event.
|
|
* Just call the poller directly to log any events.
|
|
* This could in theory increase the threshold under high load,
|
|
* but doesn't for now.
|
|
*/
|
|
static void intel_threshold_interrupt(void)
|
|
{
|
|
if (cmci_storm_detect())
|
|
return;
|
|
machine_check_poll(MCP_TIMESTAMP, &__get_cpu_var(mce_banks_owned));
|
|
mce_notify_irq();
|
|
}
|
|
|
|
/*
|
|
* Enable CMCI (Corrected Machine Check Interrupt) for available MCE banks
|
|
* on this CPU. Use the algorithm recommended in the SDM to discover shared
|
|
* banks.
|
|
*/
|
|
static void cmci_discover(int banks)
|
|
{
|
|
unsigned long *owned = (void *)&__get_cpu_var(mce_banks_owned);
|
|
unsigned long flags;
|
|
int i;
|
|
int bios_wrong_thresh = 0;
|
|
|
|
raw_spin_lock_irqsave(&cmci_discover_lock, flags);
|
|
for (i = 0; i < banks; i++) {
|
|
u64 val;
|
|
int bios_zero_thresh = 0;
|
|
|
|
if (test_bit(i, owned))
|
|
continue;
|
|
|
|
rdmsrl(MSR_IA32_MCx_CTL2(i), val);
|
|
|
|
/* Already owned by someone else? */
|
|
if (val & MCI_CTL2_CMCI_EN) {
|
|
clear_bit(i, owned);
|
|
__clear_bit(i, __get_cpu_var(mce_poll_banks));
|
|
continue;
|
|
}
|
|
|
|
if (!mce_bios_cmci_threshold) {
|
|
val &= ~MCI_CTL2_CMCI_THRESHOLD_MASK;
|
|
val |= CMCI_THRESHOLD;
|
|
} else if (!(val & MCI_CTL2_CMCI_THRESHOLD_MASK)) {
|
|
/*
|
|
* If bios_cmci_threshold boot option was specified
|
|
* but the threshold is zero, we'll try to initialize
|
|
* it to 1.
|
|
*/
|
|
bios_zero_thresh = 1;
|
|
val |= CMCI_THRESHOLD;
|
|
}
|
|
|
|
val |= MCI_CTL2_CMCI_EN;
|
|
wrmsrl(MSR_IA32_MCx_CTL2(i), val);
|
|
rdmsrl(MSR_IA32_MCx_CTL2(i), val);
|
|
|
|
/* Did the enable bit stick? -- the bank supports CMCI */
|
|
if (val & MCI_CTL2_CMCI_EN) {
|
|
set_bit(i, owned);
|
|
__clear_bit(i, __get_cpu_var(mce_poll_banks));
|
|
/*
|
|
* We are able to set thresholds for some banks that
|
|
* had a threshold of 0. This means the BIOS has not
|
|
* set the thresholds properly or does not work with
|
|
* this boot option. Note down now and report later.
|
|
*/
|
|
if (mce_bios_cmci_threshold && bios_zero_thresh &&
|
|
(val & MCI_CTL2_CMCI_THRESHOLD_MASK))
|
|
bios_wrong_thresh = 1;
|
|
} else {
|
|
WARN_ON(!test_bit(i, __get_cpu_var(mce_poll_banks)));
|
|
}
|
|
}
|
|
raw_spin_unlock_irqrestore(&cmci_discover_lock, flags);
|
|
if (mce_bios_cmci_threshold && bios_wrong_thresh) {
|
|
pr_info_once(
|
|
"bios_cmci_threshold: Some banks do not have valid thresholds set\n");
|
|
pr_info_once(
|
|
"bios_cmci_threshold: Make sure your BIOS supports this boot option\n");
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Just in case we missed an event during initialization check
|
|
* all the CMCI owned banks.
|
|
*/
|
|
void cmci_recheck(void)
|
|
{
|
|
unsigned long flags;
|
|
int banks;
|
|
|
|
if (!mce_available(__this_cpu_ptr(&cpu_info)) || !cmci_supported(&banks))
|
|
return;
|
|
local_irq_save(flags);
|
|
machine_check_poll(MCP_TIMESTAMP, &__get_cpu_var(mce_banks_owned));
|
|
local_irq_restore(flags);
|
|
}
|
|
|
|
/*
|
|
* Disable CMCI on this CPU for all banks it owns when it goes down.
|
|
* This allows other CPUs to claim the banks on rediscovery.
|
|
*/
|
|
void cmci_clear(void)
|
|
{
|
|
unsigned long flags;
|
|
int i;
|
|
int banks;
|
|
u64 val;
|
|
|
|
if (!cmci_supported(&banks))
|
|
return;
|
|
raw_spin_lock_irqsave(&cmci_discover_lock, flags);
|
|
for (i = 0; i < banks; i++) {
|
|
if (!test_bit(i, __get_cpu_var(mce_banks_owned)))
|
|
continue;
|
|
/* Disable CMCI */
|
|
rdmsrl(MSR_IA32_MCx_CTL2(i), val);
|
|
val &= ~MCI_CTL2_CMCI_EN;
|
|
wrmsrl(MSR_IA32_MCx_CTL2(i), val);
|
|
__clear_bit(i, __get_cpu_var(mce_banks_owned));
|
|
}
|
|
raw_spin_unlock_irqrestore(&cmci_discover_lock, flags);
|
|
}
|
|
|
|
static long cmci_rediscover_work_func(void *arg)
|
|
{
|
|
int banks;
|
|
|
|
/* Recheck banks in case CPUs don't all have the same */
|
|
if (cmci_supported(&banks))
|
|
cmci_discover(banks);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* After a CPU went down cycle through all the others and rediscover
|
|
* Must run in process context.
|
|
*/
|
|
void cmci_rediscover(int dying)
|
|
{
|
|
int cpu, banks;
|
|
|
|
if (!cmci_supported(&banks))
|
|
return;
|
|
|
|
for_each_online_cpu(cpu) {
|
|
if (cpu == dying)
|
|
continue;
|
|
|
|
if (cpu == smp_processor_id()) {
|
|
cmci_rediscover_work_func(NULL);
|
|
continue;
|
|
}
|
|
|
|
work_on_cpu(cpu, cmci_rediscover_work_func, NULL);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Reenable CMCI on this CPU in case a CPU down failed.
|
|
*/
|
|
void cmci_reenable(void)
|
|
{
|
|
int banks;
|
|
if (cmci_supported(&banks))
|
|
cmci_discover(banks);
|
|
}
|
|
|
|
static void intel_init_cmci(void)
|
|
{
|
|
int banks;
|
|
|
|
if (!cmci_supported(&banks))
|
|
return;
|
|
|
|
mce_threshold_vector = intel_threshold_interrupt;
|
|
cmci_discover(banks);
|
|
/*
|
|
* For CPU #0 this runs with still disabled APIC, but that's
|
|
* ok because only the vector is set up. We still do another
|
|
* check for the banks later for CPU #0 just to make sure
|
|
* to not miss any events.
|
|
*/
|
|
apic_write(APIC_LVTCMCI, THRESHOLD_APIC_VECTOR|APIC_DM_FIXED);
|
|
cmci_recheck();
|
|
}
|
|
|
|
void mce_intel_feature_init(struct cpuinfo_x86 *c)
|
|
{
|
|
intel_init_thermal(c);
|
|
intel_init_cmci();
|
|
}
|