Tang Chen 85b97637bb x86/mce: Do not change worker's running cpu in cmci_rediscover(). ... cmci_rediscover() used set_cpus_allowed_ptr() to change the current process's running cpu, and migrate itself to the dest cpu. But worker processes are not allowed to be migrated. If current is a worker, the worker will be migrated to another cpu, but the corresponding worker_pool is still on the original cpu. In this case, the following BUG_ON in try_to_wake_up_local() will be triggered: BUG_ON(rq != this_rq()); This will cause the kernel panic. The call trace is like the following: [ 6155.451107] ------------[ cut here ]------------ [ 6155.452019] kernel BUG at kernel/sched/core.c:1654! ...... [ 6155.452019] RIP: 0010:[<ffffffff810add15>] [<ffffffff810add15>] try_to_wake_up_local+0x115/0x130 ...... [ 6155.452019] Call Trace: [ 6155.452019] [<ffffffff8166fc14>] __schedule+0x764/0x880 [ 6155.452019] [<ffffffff81670059>] schedule+0x29/0x70 [ 6155.452019] [<ffffffff8166de65>] schedule_timeout+0x235/0x2d0 [ 6155.452019] [<ffffffff810db57d>] ? mark_held_locks+0x8d/0x140 [ 6155.452019] [<ffffffff810dd463>] ? __lock_release+0x133/0x1a0 [ 6155.452019] [<ffffffff81671c50>] ? _raw_spin_unlock_irq+0x30/0x50 [ 6155.452019] [<ffffffff810db8f5>] ? trace_hardirqs_on_caller+0x105/0x190 [ 6155.452019] [<ffffffff8166fefb>] wait_for_common+0x12b/0x180 [ 6155.452019] [<ffffffff810b0b30>] ? try_to_wake_up+0x2f0/0x2f0 [ 6155.452019] [<ffffffff8167002d>] wait_for_completion+0x1d/0x20 [ 6155.452019] [<ffffffff8110008a>] stop_one_cpu+0x8a/0xc0 [ 6155.452019] [<ffffffff810abd40>] ? __migrate_task+0x1a0/0x1a0 [ 6155.452019] [<ffffffff810a6ab8>] ? complete+0x28/0x60 [ 6155.452019] [<ffffffff810b0fd8>] set_cpus_allowed_ptr+0x128/0x130 [ 6155.452019] [<ffffffff81036785>] cmci_rediscover+0xf5/0x140 [ 6155.452019] [<ffffffff816643c0>] mce_cpu_callback+0x18d/0x19d [ 6155.452019] [<ffffffff81676187>] notifier_call_chain+0x67/0x150 [ 6155.452019] [<ffffffff810a03de>] __raw_notifier_call_chain+0xe/0x10 [ 6155.452019] [<ffffffff81070470>] __cpu_notify+0x20/0x40 [ 6155.452019] [<ffffffff810704a5>] cpu_notify_nofail+0x15/0x30 [ 6155.452019] [<ffffffff81655182>] _cpu_down+0x262/0x2e0 [ 6155.452019] [<ffffffff81655236>] cpu_down+0x36/0x50 [ 6155.452019] [<ffffffff813d3eaa>] acpi_processor_remove+0x50/0x11e [ 6155.452019] [<ffffffff813a6978>] acpi_device_remove+0x90/0xb2 [ 6155.452019] [<ffffffff8143cbec>] __device_release_driver+0x7c/0xf0 [ 6155.452019] [<ffffffff8143cd6f>] device_release_driver+0x2f/0x50 [ 6155.452019] [<ffffffff813a7870>] acpi_bus_remove+0x32/0x6d [ 6155.452019] [<ffffffff813a7932>] acpi_bus_trim+0x87/0xee [ 6155.452019] [<ffffffff813a7a21>] acpi_bus_hot_remove_device+0x88/0x16b [ 6155.452019] [<ffffffff813a33ee>] acpi_os_execute_deferred+0x27/0x34 [ 6155.452019] [<ffffffff81090589>] process_one_work+0x219/0x680 [ 6155.452019] [<ffffffff81090528>] ? process_one_work+0x1b8/0x680 [ 6155.452019] [<ffffffff813a33c7>] ? acpi_os_wait_events_complete+0x23/0x23 [ 6155.452019] [<ffffffff810923be>] worker_thread+0x12e/0x320 [ 6155.452019] [<ffffffff81092290>] ? manage_workers+0x110/0x110 [ 6155.452019] [<ffffffff81098396>] kthread+0xc6/0xd0 [ 6155.452019] [<ffffffff8167c4c4>] kernel_thread_helper+0x4/0x10 [ 6155.452019] [<ffffffff81671f30>] ? retint_restore_args+0x13/0x13 [ 6155.452019] [<ffffffff810982d0>] ? __init_kthread_worker+0x70/0x70 [ 6155.452019] [<ffffffff8167c4c0>] ? gs_change+0x13/0x13 This patch removes the set_cpus_allowed_ptr() call, and put the cmci rediscover jobs onto all the other cpus using system_wq. This could bring some delay for the jobs. Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com> Signed-off-by: Tony Luck <tony.luck@intel.com>		2012-10-30 14:38:12 -07:00
..
boot	x86, boot: Explicitly include autoconf.h for hostprogs	2012-10-14 12:41:28 -07:00
configs	x86/Kconfig: Turn off DEBUG_NX_TEST module in defconfigs	2012-09-05 10:43:12 +02:00
crypto	crypto: aesni - fix XTS mode on x86-32, add wrapper function for asmlinkage aesni_enc()	2012-10-18 14:01:33 -07:00
ia32	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal	2012-10-10 12:02:25 +09:00
include	EFI updates for 3.7	2012-10-26 10:17:38 +02:00
kernel	x86/mce: Do not change worker's running cpu in cmci_rediscover().	2012-10-30 14:38:12 -07:00
kvm	KVM: apic: fix LDR calculation in x2apic mode	2012-10-22 18:03:27 +02:00
lguest	virtio: remove CONFIG_VIRTIO_RING	2012-09-28 15:05:15 +09:30
lib	UAPI: x86: Fix insn_sanity build failure after UAPI split	2012-10-02 18:01:56 +01:00
math-emu
mm	x86, mm: Undo incorrect revert in arch/x86/mm/init.c	2012-10-25 15:45:45 -07:00
net	x86: bpf_jit_comp: add XOR instruction for BPF JIT	2012-09-24 16:54:35 -04:00
oprofile	oprofile, x86: Fix wrapping bug in op_x86_get_ctrl()	2012-10-15 14:38:24 +02:00
pci	PCI changes for the 3.7 merge window:	2012-10-01 12:05:36 -07:00
platform	EFI updates for 3.7	2012-10-26 10:17:38 +02:00
power
realmode	x86, suspend: Correct the restore of CR4, EFER; skip computing EFLAGS.ID	2012-10-02 08:42:31 +02:00
syscalls	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal	2012-10-10 12:02:25 +09:00
tools	UAPI: x86: Fix the test_get_len tool	2012-10-02 18:01:56 +01:00
um	Merge branch 'modules-next' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux	2012-10-14 13:39:34 -07:00
vdso	time: Convert x86_64 to using new update_vsyscall	2012-09-24 12:38:09 -04:00
video
xen	Merge commit 'v3.7-rc1' into stable/for-linus-3.7	2012-10-19 15:19:19 -04:00
.gitignore
Kbuild
Kconfig	Merge branch 'modules-next' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux	2012-10-14 13:39:34 -07:00
Kconfig.cpu	x86/Kconfig: Clean up Kconfig defaults	2012-09-13 17:45:33 +02:00
Kconfig.debug	x86/tlb: add tlb_flushall_shift knob into debugfs	2012-06-27 19:29:10 -07:00
Makefile	kbuild: Fix accidental revert in commit fe04ddf	2012-10-15 13:01:05 -07:00
Makefile_32.cpu
Makefile.um