Dave Chinner 75bcffbb9e xfs: shrink failure needs to hold AGI buffer ... Chandan reported a AGI/AGF lock order hang on xfs/168 during recent testing. The cause of the problem was the task running xfs_growfs to shrink the filesystem. A failure occurred trying to remove the free space from the btrees that the shrink would make disappear, and that meant it ran the error handling for a partial failure. This error path involves restoring the per-ag block reservations, and that requires calculating the amount of space needed to be reserved for the free inode btree. The growfs operation hung here: [18679.536829] down+0x71/0xa0 [18679.537657] xfs_buf_lock+0xa4/0x290 [xfs] [18679.538731] xfs_buf_find_lock+0xf7/0x4d0 [xfs] [18679.539920] xfs_buf_lookup.constprop.0+0x289/0x500 [xfs] [18679.542628] xfs_buf_get_map+0x2b3/0xe40 [xfs] [18679.547076] xfs_buf_read_map+0xbb/0x900 [xfs] [18679.562616] xfs_trans_read_buf_map+0x449/0xb10 [xfs] [18679.569778] xfs_read_agi+0x1cd/0x500 [xfs] [18679.573126] xfs_ialloc_read_agi+0xc2/0x5b0 [xfs] [18679.578708] xfs_finobt_calc_reserves+0xe7/0x4d0 [xfs] [18679.582480] xfs_ag_resv_init+0x2c5/0x490 [xfs] [18679.586023] xfs_ag_shrink_space+0x736/0xd30 [xfs] [18679.590730] xfs_growfs_data_private.isra.0+0x55e/0x990 [xfs] [18679.599764] xfs_growfs_data+0x2f1/0x410 [xfs] [18679.602212] xfs_file_ioctl+0xd1e/0x1370 [xfs] trying to get the AGI lock. The AGI lock was held by a fstress task trying to do an inode allocation, and it was waiting on the AGF lock to allocate a new inode chunk on disk. Hence deadlock. The fix for this is for the growfs code to hold the AGI over the transaction roll it does in the error path. It already holds the AGF locked across this, and that is what causes the lock order inversion in the xfs_ag_resv_init() call. Reported-by: Chandan Babu R <chandanbabu@kernel.org> Fixes: 46141dc891 ("xfs: introduce xfs_ag_shrink_space()") Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>		2024-03-07 14:59:05 +05:30
..
libxfs	xfs: shrink failure needs to hold AGI buffer	2024-03-07 14:59:05 +05:30
scrub	xfs: fix scrub stats file permissions	2024-02-26 17:58:37 +05:30
Kconfig	xfs: support in-memory btrees	2024-02-22 12:43:35 -08:00
Makefile	xfs: create refcount bag structure for btree repairs	2024-02-22 12:43:41 -08:00
xfs_acl.c	xfs: convert kmem_free() for kvmalloc users to kvfree()	2024-02-13 18:07:34 +05:30
xfs_acl.h
xfs_aops.c	fs: convert error_remove_page to error_remove_folio	2023-12-10 16:51:42 -08:00
xfs_aops.h
xfs_attr_inactive.c	xfs: report dir/attr block corruption errors to the health system	2024-02-22 12:32:18 -08:00
xfs_attr_item.c	xfs: add a xattr_entry helper	2024-02-22 12:44:22 -08:00
xfs_attr_item.h
xfs_attr_list.c	xfs: report XFS_IS_CORRUPT errors to the health system	2024-02-22 12:32:55 -08:00
xfs_bio_io.c
xfs_bmap_item.c	xfs: support recovering bmap intent items targetting realtime extents	2024-02-22 12:44:24 -08:00
xfs_bmap_item.h	xfs: move xfs_bmap_defer_add to xfs_bmap_item.c	2024-02-22 12:44:21 -08:00
xfs_bmap_util.c	xfs: support deferred bmap updates on the attr fork	2024-02-22 12:44:32 -08:00
xfs_bmap_util.h	xfs: indicate if xfs_bmap_adjacent changed ap->blkno	2023-12-22 11:18:11 +05:30
xfs_buf_item_recover.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_buf_item.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_buf_item.h
xfs_buf_mem.c	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_buf_mem.h	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_buf.c	xfs: support in-memory buffer cache targets	2024-02-22 12:43:21 -08:00
xfs_buf.h	xfs: support in-memory buffer cache targets	2024-02-22 12:43:21 -08:00
xfs_dahash_test.c
xfs_dahash_test.h
xfs_dir2_readdir.c	xfs: report XFS_IS_CORRUPT errors to the health system	2024-02-22 12:32:55 -08:00
xfs_discard.c	xfs: split xfs_allocbt_init_cursor	2024-02-22 12:40:12 -08:00
xfs_discard.h	xfs: move log discard work to xfs_discard.c	2023-10-04 09:24:02 +11:00
xfs_dquot_item_recover.c	xfs: dquot recovery does not validate the recovered dquot	2023-11-22 23:39:36 +05:30
xfs_dquot_item.c
xfs_dquot_item.h
xfs_dquot.c	xfs: report quota block corruption errors to the health system	2024-02-22 12:32:44 -08:00
xfs_dquot.h	xfs: repair quotas	2023-12-15 10:03:45 -08:00
xfs_drain.c
xfs_drain.h
xfs_error.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_error.h
xfs_export.c	xfs: fix reloading entire unlinked bucket lists	2023-09-24 18:12:13 -07:00
xfs_export.h
xfs_extent_busy.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_extent_busy.h	xfs: repair free space btrees	2023-12-15 10:03:32 -08:00
xfs_extfree_item.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_extfree_item.h
xfs_file.c	xfs: Replace xfs_isilocked with xfs_assert_ilocked	2024-02-19 21:19:33 +05:30
xfs_filestream.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_filestream.h
xfs_fsmap.c	xfs: split xfs_allocbt_init_cursor	2024-02-22 12:40:12 -08:00
xfs_fsmap.h
xfs_fsops.c	New code for 6.8:	2024-01-10 08:45:22 -08:00
xfs_fsops.h	xfs: clean up xfs_fsops.h	2023-12-07 14:51:07 +05:30
xfs_globals.c	xfs: add debug knobs to control btree bulk load slack factors	2023-12-15 10:03:28 -08:00
xfs_health.c	xfs: support in-memory btrees	2024-02-22 12:43:35 -08:00
xfs_hooks.c	xfs: allow scrub to hook metadata updates in other writers	2024-02-22 12:30:45 -08:00
xfs_hooks.h	xfs: allow scrub to hook metadata updates in other writers	2024-02-22 12:30:45 -08:00
xfs_icache.c	xfs: report inode corruption errors to the health system	2024-02-22 12:32:43 -08:00
xfs_icache.h	xfs: use per-mount cpumask to track nonempty percpu inodegc lists	2023-09-11 08:39:03 -07:00
xfs_icreate_item.c	xfs: convert kmem_free() for kvmalloc users to kvfree()	2024-02-13 18:07:34 +05:30
xfs_icreate_item.h
xfs_inode_item_recover.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_inode_item.c	xfs: Replace xfs_isilocked with xfs_assert_ilocked	2024-02-19 21:19:33 +05:30
xfs_inode_item.h
xfs_inode.c	xfs: remember sick inodes that get inactivated	2024-02-22 12:33:03 -08:00
xfs_inode.h	xfs: track directory entry updates during live nlinks fsck	2024-02-22 12:30:59 -08:00
xfs_ioctl32.c
xfs_ioctl32.h	arch: Remove Itanium (IA-64) architecture	2023-09-11 08:13:17 +00:00
xfs_ioctl.c	xfs: use kvfree in xfs_ioc_getfsmap()	2024-02-20 10:38:14 +05:30
xfs_ioctl.h
xfs_iomap.c	xfs: report block map corruption errors to the health tracking system	2024-02-22 12:31:51 -08:00
xfs_iomap.h
xfs_iops.c	xfs: Remove mrlock wrapper	2024-02-19 21:19:33 +05:30
xfs_iops.h
xfs_itable.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_itable.h
xfs_iunlink_item.c
xfs_iunlink_item.h
xfs_iwalk.c	xfs: remove xfs_btree_reada_bufs	2024-02-22 12:41:01 -08:00
xfs_iwalk.h
xfs_linux.h	xfs: allow scrub to hook metadata updates in other writers	2024-02-22 12:30:45 -08:00
xfs_log_cil.c	xfs: use kvfree() in xlog_cil_free_logvec()	2024-02-28 14:04:45 +05:30
xfs_log_priv.h	xfs: use xfs_defer_pending objects to recover intent items	2023-12-06 18:45:14 -08:00
xfs_log_recover.c	xfs: fix log recovery erroring out on refcount recovery failure	2024-02-24 10:43:26 +05:30
xfs_log.c	xfs: remove the xfs_buftarg_t typedef	2024-02-22 12:42:44 -08:00
xfs_log.h
xfs_message.c
xfs_message.h
xfs_mount.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_mount.h	xfs: teach buftargs to maintain their own buffer hashtable	2024-02-22 12:42:58 -08:00
xfs_mru_cache.c	xfs: use GFP_KERNEL in pure transaction contexts	2024-02-13 18:07:35 +05:30
xfs_mru_cache.h
xfs_notify_failure.c	mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind	2023-12-07 14:34:26 +05:30
xfs_pnfs.c
xfs_pnfs.h
xfs_pwork.c
xfs_pwork.h
xfs_qm_bhv.c	xfs: track quota updates during live quotacheck	2024-02-22 12:30:55 -08:00
xfs_qm_syscalls.c
xfs_qm.c	xfs: report quota block corruption errors to the health system	2024-02-22 12:32:44 -08:00
xfs_qm.h	xfs: track quota updates during live quotacheck	2024-02-22 12:30:55 -08:00
xfs_quota.h	xfs: track quota updates during live quotacheck	2024-02-22 12:30:55 -08:00
xfs_quotaops.c
xfs_refcount_item.c	xfs: place intent recovery under NOFS allocation context	2024-02-13 18:07:35 +05:30
xfs_refcount_item.h
xfs_reflink.c	xfs: support deferred bmap updates on the attr fork	2024-02-22 12:44:32 -08:00
xfs_reflink.h
xfs_rmap_item.c	xfs: place intent recovery under NOFS allocation context	2024-02-13 18:07:35 +05:30
xfs_rmap_item.h
xfs_rtalloc.c	xfs: report realtime metadata corruption errors to the health system	2024-02-22 12:32:44 -08:00
xfs_rtalloc.h	xfs: move xfs_bmap_rtalloc to xfs_rtalloc.c	2023-12-22 11:18:11 +05:30
xfs_stats.c	xfs: define an in-memory btree for storing refcount bag info during repairs	2024-02-22 12:43:40 -08:00
xfs_stats.h	xfs: define an in-memory btree for storing refcount bag info during repairs	2024-02-22 12:43:40 -08:00
xfs_super.c	xfs: port refcount repair to the new refcount bag structure	2024-02-22 12:43:42 -08:00
xfs_super.h	xfs: create scaffolding for creating debugfs entries	2023-08-10 07:48:07 -07:00
xfs_symlink.c	xfs: move symlink target write function to libxfs	2024-02-22 12:52:37 -08:00
xfs_symlink.h	xfs: move remote symlink target read function to libxfs	2024-02-22 12:45:17 -08:00
xfs_sysctl.c	fs: Remove the now superfluous sentinel elements from ctl_table array	2023-12-28 04:57:57 -08:00
xfs_sysctl.h	xfs: add debug knobs to control btree bulk load slack factors	2023-12-15 10:03:28 -08:00
xfs_sysfs.c	xfs: remove duplicate ifdefs	2024-02-17 09:32:32 +05:30
xfs_sysfs.h
xfs_trace.c	xfs: clean up bmap log intent item tracepoint callsites	2024-02-22 12:43:53 -08:00
xfs_trace.h	xfs: add a realtime flag to the bmap update log redo items	2024-02-22 12:44:23 -08:00
xfs_trans_ail.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_trans_buf.c	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_trans_dquot.c	xfs: track quota updates during live quotacheck	2024-02-22 12:30:55 -08:00
xfs_trans_priv.h
xfs_trans.c	xfs: Replace xfs_isilocked with xfs_assert_ilocked	2024-02-19 21:19:33 +05:30
xfs_trans.h	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_xattr.c	xfs: set inode sick state flags when we zap either ondisk fork	2023-12-15 10:03:35 -08:00
xfs_xattr.h	xfs: move xfs_xattr_handlers to .rodata	2023-10-10 13:49:20 +02:00
xfs.h