Dave Chinner 27a7a9d903 xfs: silence sparse warning when checking version number ... Scrub checks the superblock version number against the known good feature bits that can be set in the version mask. It calculates the version mask to compare like so: vernum_mask = cpu_to_be16(~XFS_SB_VERSION_OKBITS | XFS_SB_VERSION_NUMBITS | XFS_SB_VERSION_ALIGNBIT | XFS_SB_VERSION_DALIGNBIT | XFS_SB_VERSION_SHAREDBIT | XFS_SB_VERSION_LOGV2BIT | XFS_SB_VERSION_SECTORBIT | XFS_SB_VERSION_EXTFLGBIT | XFS_SB_VERSION_DIRV2BIT); This generates a sparse warning: fs/xfs/scrub/agheader.c:168:23: warning: cast truncates bits from constant value (ffff3f8f becomes 3f8f) This is because '~XFS_SB_VERSION_OKBITS' is considered a 32 bit constant, even though it's value is always under 16 bits. This is a kinda silly thing to do, because: /* * Supported feature bit list is just all bits in the versionnum field because * we've used them all up and understand them all. Except, of course, for the * shared superblock bit, which nobody knows what it does and so is unsupported. */ #define XFS_SB_VERSION_OKBITS \ ((XFS_SB_VERSION_NUMBITS | XFS_SB_VERSION_ALLFBITS) & \ ~XFS_SB_VERSION_SHAREDBIT) #define XFS_SB_VERSION_NUMBITS 0x000f #define XFS_SB_VERSION_ALLFBITS 0xfff0 #define XFS_SB_VERSION_SHAREDBIT 0x0200 XFS_SB_VERSION_OKBITS has a value of 0xfdff, and so ~XFS_SB_VERSION_OKBITS == XFS_SB_VERSION_SHAREDBIT. The calculated mask already sets XFS_SB_VERSION_SHAREDBIT, so starting with ~XFS_SB_VERSION_OKBITS is completely redundant.... Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>		2024-04-22 12:51:43 +05:30
..
libxfs	xfs: Increase XFS_DEFER_OPS_NR_INODES to 5	2024-04-15 14:59:01 -07:00
scrub	xfs: silence sparse warning when checking version number	2024-04-22 12:51:43 +05:30
Kconfig	xfs: support in-memory btrees	2024-02-22 12:43:35 -08:00
Makefile	xfs: online repair of symbolic links	2024-04-15 14:58:58 -07:00
xfs_acl.c	xfs: convert kmem_free() for kvmalloc users to kvfree()	2024-02-13 18:07:34 +05:30
xfs_acl.h
xfs_aops.c	xfs: don't use current->journal_info	2024-03-25 10:21:01 +05:30
xfs_aops.h
xfs_attr_inactive.c	xfs: report dir/attr block corruption errors to the health system	2024-02-22 12:32:18 -08:00
xfs_attr_item.c	xfs: add an explicit owner field to xfs_da_args	2024-04-15 14:58:50 -07:00
xfs_attr_item.h
xfs_attr_list.c	xfs: validate dabtree node buffer owners	2024-04-15 14:58:51 -07:00
xfs_bio_io.c
xfs_bmap_item.c	xfs: support recovering bmap intent items targetting realtime extents	2024-02-22 12:44:24 -08:00
xfs_bmap_item.h	xfs: move xfs_bmap_defer_add to xfs_bmap_item.c	2024-02-22 12:44:21 -08:00
xfs_bmap_util.c	xfs: hoist multi-fsb allocation unit detection to a helper	2024-04-15 14:54:11 -07:00
xfs_bmap_util.h	xfs: indicate if xfs_bmap_adjacent changed ap->blkno	2023-12-22 11:18:11 +05:30
xfs_buf_item_recover.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_buf_item.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_buf_item.h
xfs_buf_mem.c	xfs: fix dev_t usage in xmbuf tracepoints	2024-03-15 10:30:23 +05:30
xfs_buf_mem.h	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_buf.c	xfs: repair extended attributes	2024-04-15 14:58:53 -07:00
xfs_buf.h	New code for 6.9:	2024-03-13 13:52:24 -07:00
xfs_dahash_test.c
xfs_dahash_test.h
xfs_dir2_readdir.c	xfs: validate explicit directory block buffer owners	2024-04-15 14:58:52 -07:00
xfs_discard.c	xfs: fix performance problems when fstrimming a subset of a fragmented AG	2024-04-15 14:59:00 -07:00
xfs_discard.h
xfs_dquot_item_recover.c	xfs: dquot recovery does not validate the recovered dquot	2023-11-22 23:39:36 +05:30
xfs_dquot_item.c
xfs_dquot_item.h
xfs_dquot.c	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_dquot.h	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_drain.c
xfs_drain.h
xfs_error.c	xfs: add error injection to test file mapping exchange recovery	2024-04-15 14:54:19 -07:00
xfs_error.h
xfs_exchmaps_item.c	xfs: capture inode generation numbers in the ondisk exchmaps log item	2024-04-15 14:54:24 -07:00
xfs_exchmaps_item.h	xfs: create deferred log items for file mapping exchanges	2024-04-15 14:54:17 -07:00
xfs_exchrange.c	xfs: support non-power-of-two rtextsize with exchange-range	2024-04-15 14:54:23 -07:00
xfs_exchrange.h	xfs: create deferred log items for file mapping exchanges	2024-04-15 14:54:17 -07:00
xfs_export.c	xfs: hide private inodes from bulkstat and handle functions	2024-04-15 14:58:48 -07:00
xfs_export.h
xfs_extent_busy.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_extent_busy.h	xfs: repair free space btrees	2023-12-15 10:03:32 -08:00
xfs_extfree_item.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_extfree_item.h
xfs_file.c	xfs: refactor non-power-of-two alignment checks	2024-04-15 14:54:12 -07:00
xfs_file.h	xfs: create a new helper to return a file's allocation unit	2024-04-15 14:54:10 -07:00
xfs_filestream.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_filestream.h
xfs_fsmap.c	xfs: split xfs_allocbt_init_cursor	2024-02-22 12:40:12 -08:00
xfs_fsmap.h
xfs_fsops.c	New code for 6.8:	2024-01-10 08:45:22 -08:00
xfs_fsops.h	xfs: clean up xfs_fsops.h	2023-12-07 14:51:07 +05:30
xfs_globals.c	xfs: add debug knobs to control btree bulk load slack factors	2023-12-15 10:03:28 -08:00
xfs_health.c	xfs: support in-memory btrees	2024-02-22 12:43:35 -08:00
xfs_hooks.c	xfs: allow scrub to hook metadata updates in other writers	2024-02-22 12:30:45 -08:00
xfs_hooks.h	xfs: allow scrub to hook metadata updates in other writers	2024-02-22 12:30:45 -08:00
xfs_icache.c	xfs: don't use current->journal_info	2024-03-25 10:21:01 +05:30
xfs_icache.h
xfs_icreate_item.c	xfs: convert kmem_free() for kvmalloc users to kvfree()	2024-02-13 18:07:34 +05:30
xfs_icreate_item.h
xfs_inode_item_recover.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_inode_item.c	xfs: Replace xfs_isilocked with xfs_assert_ilocked	2024-02-19 21:19:33 +05:30
xfs_inode_item.h
xfs_inode.c	xfs: Hold inode locks in xfs_rename	2024-04-15 14:59:02 -07:00
xfs_inode.h	xfs: Increase XFS_DEFER_OPS_NR_INODES to 5	2024-04-15 14:59:01 -07:00
xfs_ioctl32.c
xfs_ioctl32.h
xfs_ioctl.c	xfs: introduce new file range exchange ioctl	2024-04-15 14:54:14 -07:00
xfs_ioctl.h
xfs_iomap.c	xfs: report block map corruption errors to the health tracking system	2024-02-22 12:31:51 -08:00
xfs_iomap.h
xfs_iops.c	xfs: hide private inodes from bulkstat and handle functions	2024-04-15 14:58:48 -07:00
xfs_iops.h	xfs: declare xfs_file.c symbols in xfs_file.h	2024-04-15 14:54:09 -07:00
xfs_itable.c	xfs: hide private inodes from bulkstat and handle functions	2024-04-15 14:58:48 -07:00
xfs_itable.h
xfs_iunlink_item.c
xfs_iunlink_item.h
xfs_iwalk.c	xfs: pass xfs_buf lookup flags to xfs_*read_agi	2024-04-15 14:54:03 -07:00
xfs_iwalk.h
xfs_linux.h	xfs: refactor non-power-of-two alignment checks	2024-04-15 14:54:12 -07:00
xfs_log_cil.c	xfs: fix CIL sparse lock context warnings	2024-04-20 20:23:59 +05:30
xfs_log_priv.h	xfs: fix CIL sparse lock context warnings	2024-04-20 20:23:59 +05:30
xfs_log_recover.c	xfs: capture inode generation numbers in the ondisk exchmaps log item	2024-04-15 14:54:24 -07:00
xfs_log.c	xfs: only clear log incompat flags at clean unmount	2024-04-15 14:54:06 -07:00
xfs_log.h	xfs: only clear log incompat flags at clean unmount	2024-04-15 14:54:06 -07:00
xfs_message.c
xfs_message.h
xfs_mount.c	xfs: only clear log incompat flags at clean unmount	2024-04-15 14:54:06 -07:00
xfs_mount.h	xfs: create a incompat flag for atomic file mapping exchanges	2024-04-15 14:54:15 -07:00
xfs_mru_cache.c	xfs: use GFP_KERNEL in pure transaction contexts	2024-02-13 18:07:35 +05:30
xfs_mru_cache.h
xfs_notify_failure.c	mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind	2023-12-07 14:34:26 +05:30
xfs_pnfs.c
xfs_pnfs.h
xfs_pwork.c
xfs_pwork.h
xfs_qm_bhv.c	xfs: track quota updates during live quotacheck	2024-02-22 12:30:55 -08:00
xfs_qm_syscalls.c
xfs_qm.c	xfs: Hold inode locks in xfs_ialloc	2024-04-15 14:59:02 -07:00
xfs_qm.h	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_quota.h	xfs: track quota updates during live quotacheck	2024-02-22 12:30:55 -08:00
xfs_quotaops.c
xfs_refcount_item.c	xfs: place intent recovery under NOFS allocation context	2024-02-13 18:07:35 +05:30
xfs_refcount_item.h
xfs_reflink.c	xfs: support deferred bmap updates on the attr fork	2024-02-22 12:44:32 -08:00
xfs_reflink.h
xfs_rmap_item.c	xfs: place intent recovery under NOFS allocation context	2024-02-13 18:07:35 +05:30
xfs_rmap_item.h
xfs_rtalloc.c	xfs: report realtime metadata corruption errors to the health system	2024-02-22 12:32:44 -08:00
xfs_rtalloc.h	xfs: move xfs_bmap_rtalloc to xfs_rtalloc.c	2023-12-22 11:18:11 +05:30
xfs_stats.c	xfs: define an in-memory btree for storing refcount bag info during repairs	2024-02-22 12:43:40 -08:00
xfs_stats.h	xfs: define an in-memory btree for storing refcount bag info during repairs	2024-02-22 12:43:40 -08:00
xfs_super.c	xfs: introduce a file mapping exchange log intent item	2024-04-15 14:54:16 -07:00
xfs_super.h
xfs_symlink.c	xfs: Hold inode locks in xfs_ialloc	2024-04-15 14:59:02 -07:00
xfs_symlink.h	xfs: move remote symlink target read function to libxfs	2024-02-22 12:45:17 -08:00
xfs_sysctl.c	fs: Remove the now superfluous sentinel elements from ctl_table array	2023-12-28 04:57:57 -08:00
xfs_sysctl.h	xfs: add debug knobs to control btree bulk load slack factors	2023-12-15 10:03:28 -08:00
xfs_sysfs.c	xfs: remove duplicate ifdefs	2024-02-17 09:32:32 +05:30
xfs_sysfs.h
xfs_trace.c	xfs: bind together the front and back ends of the file range exchange code	2024-04-15 14:54:18 -07:00
xfs_trace.h	xfs: repair extended attributes	2024-04-15 14:58:53 -07:00
xfs_trans_ail.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_trans_buf.c	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_trans_dquot.c	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_trans_priv.h
xfs_trans.c	xfs: Hold inode locks in xfs_trans_alloc_dir	2024-04-15 14:59:02 -07:00
xfs_trans.h	xfs: don't use current->journal_info	2024-03-25 10:21:01 +05:30
xfs_xattr.c	xfs: only clear log incompat flags at clean unmount	2024-04-15 14:54:06 -07:00
xfs_xattr.h
xfs.h