Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 06:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,235,717 Commits 7 Branches 862 Tags 6.4 GiB
57f2d20976
Commit Graph

1235717 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kent Overstreet
57f2d20976 bcachefs: Reduce would_deadlock restarts 
We don't have to take locks in any particular ordering - we'll make
forward progress just fine - but if we try to stick to an ordering, it
can help to avoid excessive would_deadlock transaction restarts.

This tweaks the reflink path to take extents btree locks in the right
order.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Kent Overstreet
5b14ce35af bcachefs: bch2_trans_account_disk_usage_change() 
The disk space accounting rewrite is splitting out accounting for each
replicas set - those are moving to btree keys, instead of percpu
counters.

This breaks bch2_trans_fs_usage_apply() up, splitting out the part we
will still need.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Kent Overstreet
8e7834a883 bcachefs: bch_fs_usage_base 
Split out base filesystem usage into its own type; prep work for
breaking up bch2_trans_fs_usage_apply().

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Kent Overstreet
4f564f4f9f bcachefs: bch2_prt_compression_type() 
bounds checking helper, since compression types are extensible

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Kent Overstreet
e58f963cec bcachefs: helpers for printing data types 
We need bounds checking since new versions may introduce new data types.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Kent Overstreet
38c23fb809 bcachefs: BTREE_TRIGGER_ATOMIC 
Add a new flag to be explicit about when we're running atomic triggers.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Kent Overstreet
9d5dba2ba8 bcachefs: drop to_text code for obsolete bps in alloc keys 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Kent Overstreet
3fe8a18640 bcachefs: eytzinger_for_each() declares loop iter 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Kent Overstreet
4ecad0da9d bcachefs: Don't log errors if BCH_WRITE_ALLOC_NOWAIT 
Previously, we added logging in the write path to ensure that any
unexpected errors getting reported to userspace have a log message; but
BCH_WRITE_ALLOC_NOWAIT is a special case, it's used for promotes where
errors are expected and not reported out to userspace - so we need to
silence those.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Su Yue
e240c1b363 bcachefs: fix memleak in bch2_split_devs 
The pointer dev_name can be modified by strseq(),
then causes the memleak:

unreferenced object 0xffff9d08a2916c80 (size 32):
  comm "mount.bcachefs", pid 9090, jiffies 4295856224 (age 17.564s)
  hex dump (first 32 bytes):
    2f 64 65 76 2f 6d 61 70 70 65 72 2f 74 65 73 74  /dev/mapper/test
    2d 30 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -0..............
  backtrace:
    [<00000000c5d3be7d>] __kmem_cache_alloc_node+0x1f3/0x2c0
    [<0000000052215d26>] __kmalloc_node_track_caller+0x51/0x150
    [<0000000069fea956>] kstrdup+0x32/0x60
    [<000000000877fcf1>] bch2_split_devs+0x3f/0x150 [bcachefs]
    [<000000007ee93204>] bch2_mount+0xcb/0x640 [bcachefs]
    [<000000002dd1e04b>] legacy_get_tree+0x30/0x60
    [<000000006afc31d3>] vfs_get_tree+0x28/0xf0
    [<000000007b0c538e>] path_mount+0x475/0xb60
    [<0000000092de5882>] __x64_sys_mount+0x105/0x140
    [<0000000054fc05d8>] do_syscall_64+0x42/0xf0
    [<00000000df584910>] entry_SYSCALL_64_after_hwframe+0x6e/0x76

Fix it by copy pointer dev_name at beginning and free the copied
pointer at end.

Signed-off-by: Su Yue <glass.su@suse.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-21 06:01:45 -05:00
Kent Overstreet
169de41985 bcachefs: eytzinger0_find() search should be const 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:46 -05:00
Kent Overstreet
f5d4481c3e bcachefs: move "ptrs not changing" optimization to bch2_trigger_extent() 
This is useful for btree ptrs as well, when we're just updating
sectors_written.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:46 -05:00
Kent Overstreet
e7999235e6 bcachefs: fix simulateously upgrading & downgrading 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
72e2c920e4 bcachefs: Restart recovery passes more reliably 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
d04d272743 bcachefs: bch2_dump_bset() doesn't choke on u64s == 0 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
4819b66e29 bcachefs: improve checksum error messages 
new helpers:
 - bch2_csum_to_text()
 - bch2_csum_err_msg()

standardize our checksum error messages a bit, and print out the
checksums a bit more nicely.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
2d02bfb01b bcachefs: improve validate_bset_keys() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
5e448c4893 bcachefs: print sb magic when relevant 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
5b88365660 bcachefs: __bch2_sb_field_to_text() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
1f5af5fc17 bcachefs: %pg is banished 
not portable to userspace

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
c13fbb7de2 bcachefs: Improve would_deadlock trace event 
We now include backtraces for every thread involved in the cycle.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
074cbcdaee bcachefs: fsck_err()s don't need to manually check c->sb.version anymore 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:21 -05:00
Kent Overstreet
15eaaa4c31 bcachefs: Upgrades now specify errors to fix, like downgrades 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
d641d4cae7 bcachefs: no thread_with_file in userspace 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
a64a37338d bcachefs: Don't autofix errors we can't fix 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
e9bc59f9df bcachefs: add missing bch2_latency_acct() call 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
4798bd2443 bcachefs: increase max_active on io_complete_wq 
this definitely should _not_ be 1, and we don't actually want any
concurrency limiting at all here - btree node read completions are
getting blocked behind btree node write submissions.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
c72e4d7a30 bcachefs: add time_stats for btree_node_read_done() 
Seeing weird latency issues in the btree node read path - add one
bch2_btree_node_read_done().

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
b819f30855 bcachefs: don't clear accessed bit in btree node fill 
Seeing strange performance issues that might be caused by memory
pressure causing prefetched nodes to be evicted before they're used.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
49a5192c0e bcachefs: Add an option to control btree node prefetching 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
8a0dda6fd6 bcachefs: kill useless return ret 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
f0431c5f47 bcachefs: Combine .trans_trigger, .atomic_trigger 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
4f9ec59f8f bcachefs: unify extent trigger 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
5a82ec3fea bcachefs: bch2_trigger_stripe_ptr() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
d55ddf6e7a bcachefs: Online fsck can now fix errors 
BCH_FS_fsck_done -> BCH_FS_fsck_running; set when we might be fixing
fsck errors. Also; set fix_errors to ask by default when fsck is
running.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
1f34c21bc6 bcachefs: bch2_trigger_pointer() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
e4eb3e5ae4 bcachefs: unify stripe trigger 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
f4f78779bb bcachefs: move stripe triggers to ec.c 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
153d1c63c2 bcachefs: unify alloc trigger 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
6820ac2cdc bcachefs: move bch2_mark_alloc() to alloc_background.c 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
6cacd0c414 bcachefs: unify reservation trigger 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
7bc4d18af4 bcachefs: unify reflink_p trigger 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:20 -05:00
Kent Overstreet
08bc959010 bcachefs: unify inode trigger 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:19 -05:00
Kent Overstreet
282e7c37eb bcachefs: kill mem_trigger_run_overwrite_then_insert() 
now that type signatures are unified, redundant

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:19 -05:00
Kent Overstreet
c95e9ec486 bcachefs: BTREE_TRIGGER_TRANSACTIONAL 
New flag so that triggers can distinguish whether we're running
transactional or atomic triggers (or gc) - unifying the callbacks.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:19 -05:00
Kent Overstreet
089e311347 bcachefs: Kill BTREE_TRIGGER_NOATOMIC 
dead code

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:19 -05:00
Kent Overstreet
ad00bce07d bcachefs: mark now takes bkey_s 
Prep work for disk space accounting rewrite: we're going to want to use
a single callback for both of our current triggers, so we need to change
them to have the same type signature first.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:19 -05:00
Kent Overstreet
717296c34c bcachefs: trans_mark now takes bkey_s 
Prep work for disk space accounting rewrite: we're going to want to use
a single callback for both of our current triggers, so we need to change
them to have the same type signature first.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:19 -05:00
Kent Overstreet
eff1f728be bcachefs: Upgrading uses bch_sb.recovery_passes_required 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:19 -05:00
Kent Overstreet
96f37eabe7 bcachefs: factor out thread_with_file, thread_with_stdio 
thread_with_stdio now knows how to handle input - fsck can now prompt to
fix errors.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2024-01-05 23:24:19 -05:00