f4c9258213
SPI NOR flashes need to erase the entire sector size and we cannot pass any arbitrary length for the erase operation. To illustrate the problem: Copying data from PC to DFU device Download [=========================] 100% 478208 bytes Download done. state(7) = dfuMANIFEST, status(0) = No error condition is present state(10) = dfuERROR, status(14) = Something went wrong, but the device does not know what it was Done! In this case, the binary has 478208 bytes and the M25P32 SPI NOR has an erase sector of 64kB. 478208 = 7 entire sectors of 64kiB + 19456 bytes. Erasing the first seven 64 kB sectors works fine, but when trying to erase the remainding 19456 causes problem and the board hangs. Fix the issue by always erasing with the erase sector size. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
142 lines
2.9 KiB
C
142 lines
2.9 KiB
C
/*
|
|
* Copyright (c) 2014, NVIDIA CORPORATION. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <malloc.h>
|
|
#include <errno.h>
|
|
#include <div64.h>
|
|
#include <dfu.h>
|
|
#include <spi.h>
|
|
#include <spi_flash.h>
|
|
|
|
static long dfu_get_medium_size_sf(struct dfu_entity *dfu)
|
|
{
|
|
return dfu->data.sf.size;
|
|
}
|
|
|
|
static int dfu_read_medium_sf(struct dfu_entity *dfu, u64 offset, void *buf,
|
|
long *len)
|
|
{
|
|
return spi_flash_read(dfu->data.sf.dev, offset, *len, buf);
|
|
}
|
|
|
|
static int dfu_write_medium_sf(struct dfu_entity *dfu,
|
|
u64 offset, void *buf, long *len)
|
|
{
|
|
int ret;
|
|
|
|
ret = spi_flash_erase(dfu->data.sf.dev, offset,
|
|
dfu->data.sf.dev->sector_size);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = spi_flash_write(dfu->data.sf.dev, offset, *len, buf);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int dfu_flush_medium_sf(struct dfu_entity *dfu)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static unsigned int dfu_polltimeout_sf(struct dfu_entity *dfu)
|
|
{
|
|
return DFU_DEFAULT_POLL_TIMEOUT;
|
|
}
|
|
|
|
static void dfu_free_entity_sf(struct dfu_entity *dfu)
|
|
{
|
|
spi_flash_free(dfu->data.sf.dev);
|
|
}
|
|
|
|
static struct spi_flash *parse_dev(char *devstr)
|
|
{
|
|
unsigned int bus;
|
|
unsigned int cs;
|
|
unsigned int speed = CONFIG_SF_DEFAULT_SPEED;
|
|
unsigned int mode = CONFIG_SF_DEFAULT_MODE;
|
|
char *s, *endp;
|
|
struct spi_flash *dev;
|
|
|
|
s = strsep(&devstr, ":");
|
|
if (!s || !*s || (bus = simple_strtoul(s, &endp, 0), *endp)) {
|
|
printf("Invalid SPI bus %s\n", s);
|
|
return NULL;
|
|
}
|
|
|
|
s = strsep(&devstr, ":");
|
|
if (!s || !*s || (cs = simple_strtoul(s, &endp, 0), *endp)) {
|
|
printf("Invalid SPI chip-select %s\n", s);
|
|
return NULL;
|
|
}
|
|
|
|
s = strsep(&devstr, ":");
|
|
if (s && *s) {
|
|
speed = simple_strtoul(s, &endp, 0);
|
|
if (*endp || !speed) {
|
|
printf("Invalid SPI speed %s\n", s);
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
s = strsep(&devstr, ":");
|
|
if (s && *s) {
|
|
mode = simple_strtoul(s, &endp, 0);
|
|
if (*endp || mode > 3) {
|
|
printf("Invalid SPI mode %s\n", s);
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
dev = spi_flash_probe(bus, cs, speed, mode);
|
|
if (!dev) {
|
|
printf("Failed to create SPI flash at %d:%d:%d:%d\n",
|
|
bus, cs, speed, mode);
|
|
return NULL;
|
|
}
|
|
|
|
return dev;
|
|
}
|
|
|
|
int dfu_fill_entity_sf(struct dfu_entity *dfu, char *devstr, char *s)
|
|
{
|
|
char *st;
|
|
|
|
dfu->data.sf.dev = parse_dev(devstr);
|
|
if (!dfu->data.sf.dev)
|
|
return -ENODEV;
|
|
|
|
dfu->dev_type = DFU_DEV_SF;
|
|
dfu->max_buf_size = dfu->data.sf.dev->sector_size;
|
|
|
|
st = strsep(&s, " ");
|
|
if (!strcmp(st, "raw")) {
|
|
dfu->layout = DFU_RAW_ADDR;
|
|
dfu->data.sf.start = simple_strtoul(s, &s, 16);
|
|
s++;
|
|
dfu->data.sf.size = simple_strtoul(s, &s, 16);
|
|
} else {
|
|
printf("%s: Memory layout (%s) not supported!\n", __func__, st);
|
|
spi_flash_free(dfu->data.sf.dev);
|
|
return -1;
|
|
}
|
|
|
|
dfu->get_medium_size = dfu_get_medium_size_sf;
|
|
dfu->read_medium = dfu_read_medium_sf;
|
|
dfu->write_medium = dfu_write_medium_sf;
|
|
dfu->flush_medium = dfu_flush_medium_sf;
|
|
dfu->poll_timeout = dfu_polltimeout_sf;
|
|
dfu->free_entity = dfu_free_entity_sf;
|
|
|
|
/* initial state */
|
|
dfu->inited = 0;
|
|
|
|
return 0;
|
|
}
|