e02ee2548a
When Kconfig for U-boot was examined, one of the biggest issues was how to support multiple images (Normal, SPL, TPL). There were actually two options, "single .config" and "multiple .config". After some discussions and thought experiments, I chose the latter, i.e. to create ".config", "spl/.config", "tpl/.config" for Normal, SPL, TPL, respectively. It is true that the "multiple .config" strategy provided us the maximum flexibility and helped to avoid duplicating CONFIGs among Normal, SPL, TPL, but I have noticed some fatal problems: [1] It is impossible to share CONFIG options across the images. If you change the configuration of Main image, you often have to adjust some SPL configurations correspondingly. Currently, we cannot handle the dependencies between them. It means one of the biggest advantages of Kconfig is lost. [2] It is too painful to change both ".config" and "spl/.config". Sunxi guys started to work around this problem by creating a new configuration target. Commitcbdd9a9737(sunxi: kconfig: Add %_felconfig rule to enable FEL build of sunxi platforms.) added "make *_felconfig" to enable CONFIG_SPL_FEL on both images. Changing the configuration of multiple images in one command is a generic demand. The current implementation cannot propose any good solution about this. [3] Kconfig files are getting ugly and difficult to understand. Commitb724bd7d63(dm: Kconfig: Move CONFIG_SYS_MALLOC_F_LEN to Kconfig) has sprinkled "if !SPL_BUILD" over the Kconfig files. [4] The build system got more complicated than it should be. To adjust Linux-originated Kconfig to U-Boot, the helper script "scripts/multiconfig.sh" was introduced. Writing a complicated text processor is a shell script sometimes caused problems. Now I believe the "single .config" will serve us better. With it, all the problems above would go away. Instead, we will have to add some CONFIG_SPL_* (and CONFIG_TPL_*) options such as CONFIG_SPL_DM, but we will not have much. Anyway, this is what we do now in scripts/Makefile.spl. I admit my mistake with my apology and this commit switches to the single .config configuration. It is not so difficult to do that: - Remove unnecessary processings from scripts/multiconfig.sh This file will remain for a while to support the current defconfig format. It will be removed after more cleanups are done. - Adjust some makefiles and Kconfigs - Add some entries to include/config_uncmd_spl.h and the new file scripts/Makefile.uncmd_spl. Some CONFIG options that are not supported on SPL must be disabled because one .config is shared between SPL and U-Boot proper going forward. I know this is not a beautiful solution and I think we can do better, but let's see how much we will have to describe them. - update doc/README.kconfig More cleaning up patches will follow this. Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Reviewed-by: Simon Glass <sjg@chromium.org>
103 lines
2.5 KiB
Bash
Executable File
103 lines
2.5 KiB
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# A wrapper script to adjust Kconfig for U-Boot
|
|
#
|
|
# This file will be removed after cleaning up defconfig files
|
|
#
|
|
# Copyright (C) 2014, Masahiro Yamada <yamada.m@jp.panasonic.com>
|
|
#
|
|
# SPDX-License-Identifier: GPL-2.0+
|
|
#
|
|
|
|
set -e
|
|
|
|
# Make a configuration target
|
|
# Usage:
|
|
# run_make_config <target> <objdir>
|
|
# <target>: Make target such as "config", "menuconfig", "defconfig", etc.
|
|
run_make_config () {
|
|
# Linux expects defconfig files in arch/$(SRCARCH)/configs/ directory,
|
|
# but U-Boot has them in configs/ directory.
|
|
# Give SRCARCH=.. to fake scripts/kconfig/Makefile.
|
|
$MAKE -f $srctree/scripts/Makefile.build obj=scripts/kconfig SRCARCH=.. $1
|
|
}
|
|
|
|
do_silentoldconfig () {
|
|
run_make_config silentoldconfig
|
|
|
|
# If the following part fails, include/config/auto.conf should be
|
|
# deleted so "make silentoldconfig" will be re-run on the next build.
|
|
$MAKE -f $srctree/scripts/Makefile.autoconf || {
|
|
rm -f include/config/auto.conf
|
|
exit 1
|
|
}
|
|
|
|
# include/config.h has been updated after "make silentoldconfig".
|
|
# We need to touch include/config/auto.conf so it gets newer
|
|
# than include/config.h.
|
|
# Otherwise, 'make silentoldconfig' would be invoked twice.
|
|
touch include/config/auto.conf
|
|
}
|
|
|
|
cleanup_after_defconfig () {
|
|
rm -f configs/.tmp_defconfig
|
|
# ignore 'Directory not empty' error
|
|
# without using non-POSIX option '--ignore-fail-on-non-empty'
|
|
rmdir arch configs 2>/dev/null || true
|
|
}
|
|
|
|
# Usage:
|
|
# do_board_defconfig <board>_defconfig
|
|
do_board_defconfig () {
|
|
defconfig_path=$srctree/configs/$1
|
|
|
|
if [ ! -r $defconfig_path ]; then
|
|
echo >&2 "***"
|
|
echo >&2 "*** Can't find default configuration \"configs/$1\"!"
|
|
echo >&2 "***"
|
|
exit 1
|
|
fi
|
|
|
|
mkdir -p arch configs
|
|
# prefix "*:" is deprecated. Drop it simply.
|
|
sed -e 's/^[+A-Z]*://' $defconfig_path > configs/.tmp_defconfig
|
|
|
|
run_make_config .tmp_defconfig || {
|
|
cleanup_after_defconfig
|
|
exit 1
|
|
}
|
|
|
|
cleanup_after_defconfig
|
|
}
|
|
|
|
do_board_felconfig () {
|
|
do_board_defconfig ${1%%_felconfig}_defconfig
|
|
if ! grep -q CONFIG_ARCH_SUNXI=y .config || ! grep -q CONFIG_SPL=y .config ; then
|
|
echo "$progname: Cannot felconfig a non-sunxi or non-SPL platform" >&2
|
|
exit 1
|
|
fi
|
|
sed -i -e 's/\# CONFIG_SPL_FEL is not set/CONFIG_SPL_FEL=y\nCONFIG_UART0_PORT_F=n/g' \
|
|
.config
|
|
}
|
|
|
|
do_others () {
|
|
run_make_config $1
|
|
}
|
|
|
|
progname=$(basename $0)
|
|
target=$1
|
|
|
|
case $target in
|
|
*_defconfig)
|
|
do_board_defconfig $target;;
|
|
*_felconfig)
|
|
do_board_felconfig $target;;
|
|
*_config)
|
|
# backward compatibility
|
|
do_board_defconfig ${target%_config}_defconfig;;
|
|
silentoldconfig)
|
|
do_silentoldconfig;;
|
|
*)
|
|
do_others $target;;
|
|
esac
|