c726fc01cf
There is a number of users that use uclass_first_device to access the first and (assumed) only device in uclass. Some check the return value of uclass_first_device and also that a device was returned which is exactly what uclass_first_device_err does. Some are not checking that a device was returned and can potentially crash if no device exists in the uclass. Finally there is one that returns NULL on error either way. Convert all of these to use uclass_first_device_err instead, the return value will be removed from uclass_first_device in a later patch. Signed-off-by: Michal Suchanek <msuchanek@suse.de> Reviewed-by: Simon Glass <sjg@chromium.org>
53 lines
1.4 KiB
C
53 lines
1.4 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (c) 2022 Google, Inc.
|
|
* Written by Andrew Scull <ascull@google.com>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <dm.h>
|
|
#include <virtio_types.h>
|
|
#include <virtio.h>
|
|
#include <virtio_ring.h>
|
|
#include <dm/device-internal.h>
|
|
#include <dm/test.h>
|
|
#include <rng.h>
|
|
#include <test/test.h>
|
|
#include <test/ut.h>
|
|
|
|
/* This is a brittle means of getting access to the virtqueue */
|
|
struct virtio_rng_priv {
|
|
struct virtqueue *rng_vq;
|
|
};
|
|
|
|
/* Test the virtio-rng driver validates the used size */
|
|
static int dm_test_virtio_rng_check_len(struct unit_test_state *uts)
|
|
{
|
|
struct udevice *bus, *dev;
|
|
struct virtio_rng_priv *priv;
|
|
u8 buffer[16];
|
|
|
|
/* check probe success */
|
|
ut_assertok(uclass_first_device_err(UCLASS_VIRTIO, &bus));
|
|
ut_assertnonnull(bus);
|
|
|
|
/* check the child virtio-rng device is bound */
|
|
ut_assertok(device_find_first_child(bus, &dev));
|
|
ut_assertnonnull(dev);
|
|
|
|
/* probe the virtio-rng driver */
|
|
ut_assertok(device_probe(dev));
|
|
|
|
/* simulate the device returning the buffer with too much data */
|
|
priv = dev_get_priv(dev);
|
|
priv->rng_vq->vring.used->idx = 1;
|
|
priv->rng_vq->vring.used->ring[0].id = 0;
|
|
priv->rng_vq->vring.used->ring[0].len = U32_MAX;
|
|
|
|
/* check the driver gracefully handles the error */
|
|
ut_asserteq(-EIO, dm_rng_read(dev, buffer, sizeof(buffer)));
|
|
|
|
return 0;
|
|
}
|
|
DM_TEST(dm_test_virtio_rng_check_len, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
|