leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

board: ti: use positive logic to detect idk boards

Browse Source 
am57x_idk_lcd_detect() exits immediately if a known board not having
an LCD is found, i.e. a non-IDK board. This is annoying as we have to
remember to add an extra OR clause for every new non-IDK board.

Add a board_is_ti_idk() macro so that the logic becomes positive (detect
LCD on IDK boards instead of not-known-without-LCD boards). Even more
important, add the macro just below the board_is_*_idk() macros, so it is
easy to remember to update it when adding a new IDK.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
This commit is contained in:
Luca Ceresoli 2020-05-21 15:06:25 +02:00 committed by Lokesh Vutla
parent 1c162722d7
commit fedfa374ff
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
board/ti/am57xx/board.c
View File

@ -61,6 +61,10 @@ static int board_bootmode_has_emmc(void);
#define board_is_am571x_idk() board_ti_is("AM571IDK")
#define board_is_bbai() board_ti_is("BBONE-AI")
#define board_is_ti_idk() board_is_am574x_idk() || \
board_is_am572x_idk() || \
board_is_am571x_idk()
#ifdef CONFIG_DRIVER_TI_CPSW
#include <cpsw.h>
#endif
@ -666,7 +670,7 @@ void am57x_idk_lcd_detect(void)
struct udevice *dev;
/* Only valid for IDKs */
if (board_is_x15() || board_is_am572x_evm() || board_is_bbai())
if (!board_is_ti_idk())
return;
/* Only AM571x IDK has gpio control detect.. so check that */