leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arm/km: fix wrong error handling

Browse Source 
miiphy_read and miiphy_write are returning 0 on success.

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Acked-by: Valentin Longchamp <valentin.longchamp@keymile.com>
This commit is contained in:
Holger Brunck 2014-01-27 16:58:26 +01:00 committed by Albert ARIBAUD
parent 56cde17760
commit fa6e0ecb8a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
board/keymile/km_arm/km_arm.c
View File

@ -318,15 +318,15 @@ void reset_phy(void)
return; return;
/* RGMII clk transition on data stable */ /* RGMII clk transition on data stable */
if (!miiphy_read(name, CONFIG_PHY_BASE_ADR, PHY_SPEC_CTRL_REG, &reg)) if (miiphy_read(name, CONFIG_PHY_BASE_ADR, PHY_SPEC_CTRL_REG, &reg))
printf("Error reading PHY spec ctrl reg\n"); printf("Error reading PHY spec ctrl reg\n");
if (!miiphy_write(name, CONFIG_PHY_BASE_ADR, PHY_SPEC_CTRL_REG, if (miiphy_write(name, CONFIG_PHY_BASE_ADR, PHY_SPEC_CTRL_REG,
reg | PHY_RGMII_CLK_STABLE | PHY_CLSA)) reg | PHY_RGMII_CLK_STABLE | PHY_CLSA))
printf("Error writing PHY spec ctrl reg\n"); printf("Error writing PHY spec ctrl reg\n");
/* leds setup */ /* leds setup */
if (!miiphy_write(name, CONFIG_PHY_BASE_ADR, PHY_LED_SEL_REG, if (miiphy_write(name, CONFIG_PHY_BASE_ADR, PHY_LED_SEL_REG,
PHY_LED0_LINK | PHY_LED1_ACT | PHY_LED2_INT)) PHY_LED0_LINK | PHY_LED1_ACT | PHY_LED2_INT))
printf("Error writing PHY LED reg\n"); printf("Error writing PHY LED reg\n");
/* reset the phy */ /* reset the phy */