leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kwbimage: check return value of image_get_csk_index

Browse Source 
image_get_csk_index() may return -1 in case of an error. Don't use this
value as index.

This resolves Coverity CID 338488
Memory - illegal accesses  (NEGATIVE_RETURNS)

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Pali Rohár <pali@kernel.org>
This commit is contained in:
Heinrich Schuchardt
2021-08-17 07:11:58 +02:00
committed by Stefan Roese
parent f858bb2e6c
commit f0317d7882
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/kwbimage.c
View File

@@ -1087,7 +1087,7 @@ int kwb_sign_csk_with_kak(struct image_tool_params *params,
int csk_idx = image_get_csk_index(); int csk_idx = image_get_csk_index();
struct sig_v1 tmp_sig; struct sig_v1 tmp_sig;
if (csk_idx >= 16) { if (csk_idx < 0 || csk_idx > 15) {
fprintf(stderr, "Invalid CSK index %d\n", csk_idx); fprintf(stderr, "Invalid CSK index %d\n", csk_idx);
return 1; return 1;
} }