leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cyclic: Don't disable cylic function upon exceeding CPU time

Browse Source 
With the migration of the watchdog infrastructure to cyclic functions
it's been noticed, that at least one watchdog driver is broken now. As
the execution time of it's watchdog reset function is quite long.

In general it's not really necessary (right now) to disable the cyclic
function upon exceeding CPU time usage. So instead of disabling the
cylic function in this case, let's just print a warning once to show
this potential problem to the user.

Signed-off-by: Stefan Roese <sr@denx.de>
Suggested-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Tom Rini <trini@konsulko.com>
Cc: Pali Rohár <pali@kernel.org>
This commit is contained in:
Stefan Roese 2022-10-17 09:00:58 +02:00
parent 374d5d9971
commit ddc8d36a74
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
common/cyclic.c
View File

@ -85,13 +85,17 @@ void cyclic_run(void)
cyclic->cpu_time_us += cpu_time;
/* Check if cpu-time exceeds max allowed time */
if (cpu_time > CONFIG_CYCLIC_MAX_CPU_TIME_US) {
pr_err("cyclic function %s took too long: %lldus vs %dus max, disabling\n",
if ((cpu_time > CONFIG_CYCLIC_MAX_CPU_TIME_US) &&
(!cyclic->already_warned)) {
pr_err("cyclic function %s took too long: %lldus vs %dus max\n",
cyclic->name, cpu_time,
CONFIG_CYCLIC_MAX_CPU_TIME_US);
/* Unregister this cyclic function */
cyclic_unregister(cyclic);
/*
* Don't disable this function, just warn once
* about this exceeding CPU time usage
*/
cyclic->already_warned = true;
}
}
}

2
include/cyclic.h
View File

@ -39,6 +39,7 @@ struct cyclic_drv {
* @run_cnt: Counter of executions occurances
* @next_call: Next time in us, when the function shall be executed again
* @list: List node
* @already_warned: Flag that we've warned about exceeding CPU time usage
*/
struct cyclic_info {
void (*func)(void *ctx);
@ -50,6 +51,7 @@ struct cyclic_info {
uint64_t run_cnt;
uint64_t next_call;
struct list_head list;
bool already_warned;
};
/** Function type for cyclic functions */