leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: dm: pci: Remove unnecessary steps in dm_test_pci_swapcase()

Browse Source 
The check on uclass_get_device() and device_active() is unnecessary
as the follow-up test operations will implicitly probe the driver.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Bin Meng 2018-08-03 01:14:38 -07:00 committed by Simon Glass
parent 64e45f73bd
commit dd4808f9fa
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/dm/pci.c
View File

@ -34,14 +34,12 @@ DM_TEST(dm_test_pci_busnum, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
/* Test that we can use the swapcase device correctly */ /* Test that we can use the swapcase device correctly */
static int dm_test_pci_swapcase(struct unit_test_state *uts) static int dm_test_pci_swapcase(struct unit_test_state *uts)
{ {
struct udevice *emul, *swap; struct udevice *swap;
ulong io_addr, mem_addr; ulong io_addr, mem_addr;
char *ptr; char *ptr;
/* Check that asking for the device automatically fires up PCI */ /* Check that asking for the device automatically fires up PCI */
ut_assertok(uclass_get_device(UCLASS_PCI_EMUL, 0, &emul));
ut_assertok(dm_pci_bus_find_bdf(PCI_BDF(0, 0x1f, 0), &swap)); ut_assertok(dm_pci_bus_find_bdf(PCI_BDF(0, 0x1f, 0), &swap));
ut_assert(device_active(swap));
/* First test I/O */ /* First test I/O */
io_addr = dm_pci_read_bar32(swap, 0); io_addr = dm_pci_read_bar32(swap, 0);