patman: Modify functional tests for new behavior
This patch adds or modifies functional tests for the Cover-changes, Commit-changes, and Series-process-log tags in order to account for new behavior added in the previous few patches. The '(no changes since v1)' case is not tested for, since that would need an additional commit to test in addition to testing the existing code paths. Signed-off-by: Sean Anderson <seanga2@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
parent
0411fff36f
commit
dc03ba48be
@ -82,19 +82,33 @@ class TestFunctional(unittest.TestCase):
|
||||
Series-prefix: RFC
|
||||
Series-cc: Stefan Brüns <stefan.bruens@rwth-aachen.de>
|
||||
Cover-letter-cc: Lord Mëlchett <clergy@palace.gov>
|
||||
Series-version: 2
|
||||
Series-version: 3
|
||||
Patch-cc: fred
|
||||
Series-process-log: sort, uniq
|
||||
Series-changes: 4
|
||||
- Some changes
|
||||
- Multi
|
||||
line
|
||||
change
|
||||
|
||||
Commit-changes: 2
|
||||
- Changes only for this commit
|
||||
|
||||
Cover-changes: 4
|
||||
- Some notes for the cover letter
|
||||
|
||||
Cover-letter:
|
||||
test: A test patch series
|
||||
This is a test of how the cover
|
||||
leter
|
||||
letter
|
||||
works
|
||||
END
|
||||
|
||||
and this in the first commit:
|
||||
|
||||
Commit-changes: 2
|
||||
- second revision change
|
||||
|
||||
Series-notes:
|
||||
some notes
|
||||
about some things
|
||||
@ -202,7 +216,7 @@ class TestFunctional(unittest.TestCase):
|
||||
|
||||
expected = '''
|
||||
This is a test of how the cover
|
||||
leter
|
||||
letter
|
||||
works
|
||||
|
||||
some notes
|
||||
@ -210,7 +224,11 @@ about some things
|
||||
from the first commit
|
||||
|
||||
Changes in v4:
|
||||
- Multi
|
||||
line
|
||||
change
|
||||
- Some changes
|
||||
- Some notes for the cover letter
|
||||
|
||||
Simon Glass (2):
|
||||
pci: Correct cast for sandbox
|
||||
@ -237,8 +255,34 @@ Simon Glass (2):
|
||||
subject = [line for line in lines if line.startswith('Subject')]
|
||||
self.assertEqual('Subject: [RFC %d/%d]' % (i + 1, count),
|
||||
subject[0][:18])
|
||||
|
||||
# Check that we got our commit notes
|
||||
start = 0
|
||||
expected = ''
|
||||
|
||||
if i == 0:
|
||||
# Check that we got our commit notes
|
||||
self.assertEqual('---', lines[17])
|
||||
self.assertEqual('Some notes about', lines[18])
|
||||
self.assertEqual('the first commit', lines[19])
|
||||
start = 17
|
||||
expected = '''---
|
||||
Some notes about
|
||||
the first commit
|
||||
|
||||
(no changes since v2)
|
||||
|
||||
Changes in v2:
|
||||
- second revision change'''
|
||||
elif i == 1:
|
||||
start = 17
|
||||
expected = '''---
|
||||
|
||||
Changes in v4:
|
||||
- Multi
|
||||
line
|
||||
change
|
||||
- Some changes
|
||||
|
||||
Changes in v2:
|
||||
- Changes only for this commit'''
|
||||
|
||||
if expected:
|
||||
expected = expected.splitlines()
|
||||
self.assertEqual(expected, lines[start:(start+len(expected))])
|
||||
|
@ -15,6 +15,9 @@ cmd/pci.c:152:11: warning: format ‘%llx’ expects argument of type
|
||||
Fix it with a cast.
|
||||
|
||||
Signed-off-by: Simon Glass <sjg@chromium.org>
|
||||
Commit-changes: 2
|
||||
- Changes only for this commit
|
||||
|
||||
Series-notes:
|
||||
some notes
|
||||
about some things
|
||||
|
@ -21,13 +21,23 @@ Series-cc: Stefan Brüns <stefan.bruens@rwth-aachen.de>
|
||||
Cover-letter-cc: Lord Mëlchett <clergy@palace.gov>
|
||||
Series-version: 3
|
||||
Patch-cc: fred
|
||||
Series-process-log: sort, uniq
|
||||
Series-changes: 4
|
||||
- Some changes
|
||||
- Multi
|
||||
line
|
||||
change
|
||||
|
||||
Commit-changes: 2
|
||||
- Changes only for this commit
|
||||
|
||||
Cover-changes: 4
|
||||
- Some notes for the cover letter
|
||||
|
||||
Cover-letter:
|
||||
test: A test patch series
|
||||
This is a test of how the cover
|
||||
leter
|
||||
letter
|
||||
works
|
||||
END
|
||||
---
|
||||
|
@ -13,6 +13,9 @@ Date: Sat Apr 15 15:39:08 2017 -0600
|
||||
Fix it with a cast.
|
||||
|
||||
Signed-off-by: Simon Glass <sjg@chromium.org>
|
||||
Commit-changes: 2
|
||||
- second revision change
|
||||
|
||||
Series-notes:
|
||||
some notes
|
||||
about some things
|
||||
@ -45,12 +48,22 @@ Date: Sat Apr 15 15:39:08 2017 -0600
|
||||
Cover-letter-cc: Lord Mëlchett <clergy@palace.gov>
|
||||
Series-version: 3
|
||||
Patch-cc: fred
|
||||
Series-process-log: sort, uniq
|
||||
Series-changes: 4
|
||||
- Some changes
|
||||
- Multi
|
||||
line
|
||||
change
|
||||
|
||||
Commit-changes: 2
|
||||
- Changes only for this commit
|
||||
|
||||
Cover-changes: 4
|
||||
- Some notes for the cover letter
|
||||
|
||||
Cover-letter:
|
||||
test: A test patch series
|
||||
This is a test of how the cover
|
||||
leter
|
||||
letter
|
||||
works
|
||||
END
|
||||
|
Loading…
Reference in New Issue
Block a user