leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

efi_selftest: fix test_hii_string_get_string()

Browse Source 
The check testing the string result of get_string() returned the wrong
result. The result was ignored.

Use efi_st_strcmp_16_8() for the string comparison.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
Heinrich Schuchardt 2019-03-19 20:08:46 +01:00
parent 1646e0928c
commit d0bd87612f
1 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/efi_selftest/efi_selftest_hii.c
View File

@ -783,19 +783,10 @@ static int test_hii_string_get_string(void)
goto out;
}
#if 1
u16 *c1, *c2;
for (c1 = string, c2 = L"Japanese"; *c1 == *c2; c1++, c2++)
;
if (!*c1 && !*c2)
result = EFI_ST_SUCCESS;
else
result = EFI_ST_FAILURE;
#else
/* TODO: %ls */
efi_st_printf("got string is %s (can be wrong)\n", string);
#endif
if (efi_st_strcmp_16_8(string, "Japanese")) {
efi_st_error("get_string returned incorrect string\n");
goto out;
}
result = EFI_ST_SUCCESS;