leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ddr: altera: Clean up rw_mgr_mem_calibrate_writes_center() part 4

Browse Source 
Fix return values to match the common return value convention.

Signed-off-by: Marek Vasut <marex@denx.de>
This commit is contained in:
Marek Vasut 2015-07-21 05:32:49 +02:00
parent c654087206
commit d043ee5b49
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/ddr/altera/sequencer.c
View File

@ -3024,7 +3024,7 @@ rw_mgr_mem_calibrate_writes_center(const u32 rank_bgn, const u32 write_group,
if (ret) { if (ret) {
set_failing_group_stage(test_bgn + ret - 1, CAL_STAGE_WRITES, set_failing_group_stage(test_bgn + ret - 1, CAL_STAGE_WRITES,
CAL_SUBSTAGE_WRITES_CENTER); CAL_SUBSTAGE_WRITES_CENTER);
return 0; return -EINVAL;
} }
min_index = get_window_mid_index(1, left_edge, right_edge, &mid_min); min_index = get_window_mid_index(1, left_edge, right_edge, &mid_min);
@ -3121,7 +3121,10 @@ rw_mgr_mem_calibrate_writes_center(const u32 rank_bgn, const u32 write_group,
*/ */
writel(0, &sdr_scc_mgr->update); writel(0, &sdr_scc_mgr->update);
return (dq_margin >= 0) && (dqs_margin >= 0) && (dm_margin >= 0); if ((dq_margin < 0) || (dqs_margin < 0) || (dm_margin < 0))
return -EINVAL;
return 0;
} }
/** /**
@ -3148,13 +3151,11 @@ static int rw_mgr_mem_calibrate_writes(const u32 rank_bgn, const u32 group,
reg_file_set_sub_stage(CAL_SUBSTAGE_WRITES_CENTER); reg_file_set_sub_stage(CAL_SUBSTAGE_WRITES_CENTER);
ret = rw_mgr_mem_calibrate_writes_center(rank_bgn, group, test_bgn); ret = rw_mgr_mem_calibrate_writes_center(rank_bgn, group, test_bgn);
if (!ret) { if (ret)
set_failing_group_stage(group, CAL_STAGE_WRITES, set_failing_group_stage(group, CAL_STAGE_WRITES,
CAL_SUBSTAGE_WRITES_CENTER); CAL_SUBSTAGE_WRITES_CENTER);
return -EIO;
}
return 0; return ret;
} }
/** /**