leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xilinx: zynqmp: Remove one static variable

Browse Source 
There is no reason to have name variable saved in BSS section when it
doesn't need to be really used. That's why remove static from variable
definition and use strdup() to duplicate string with exact size from malloc
area instead.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
This commit is contained in:
Michal Simek 2020-08-05 12:41:35 +02:00
parent e17c5ec8e1
commit ced4d46626
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
board/xilinx/zynqmp/zynqmp.c
View File

@ -190,7 +190,7 @@ static char *zynqmp_get_silicon_idcode_name(void)
{
u32 i;
u32 idcode, idcode2;
static char name[ZYNQMP_VERSION_SIZE];
char name[ZYNQMP_VERSION_SIZE];
u32 ret_payload[PAYLOAD_ARG_CNT];
xilinx_pm_request(PM_GET_CHIPID, 0, 0, 0, 0, ret_payload);
@ -218,7 +218,7 @@ static char *zynqmp_get_silicon_idcode_name(void)
return "unknown";
/* Add device prefix to the name */
strncat(name, "zu", 2);
strncpy(name, "zu", ZYNQMP_VERSION_SIZE);
strncat(&name[2], simple_itoa(zynqmp_devices[i].device), 2);
if (zynqmp_devices[i].variants & ZYNQMP_VARIANT_EV) {
@ -268,7 +268,7 @@ static char *zynqmp_get_silicon_idcode_name(void)
debug("Variant not identified\n");
}
return name;
return strdup(name);
}
#endif