image: Adjust the workings of fit_check_format()
At present this function does not accept a size for the FIT. This means that it must be read from the FIT itself, introducing potential security risk. Update the function to include a size parameter, which can be invalid, in which case fit_check_format() calculates it. For now no callers pass the size, but this can be updated later. Also adjust the return value to an error code so that all the different types of problems can be distinguished by the user. Signed-off-by: Simon Glass <sjg@chromium.org> Reported-by: Bruce Monroe <bruce.monroe@intel.com> Reported-by: Arie Haenel <arie.haenel@intel.com> Reported-by: Julien Lenoir <julien.lenoir@intel.com>
This commit is contained in:
@@ -317,7 +317,7 @@ __weak bool sec_firmware_is_valid(const void *sec_firmware_img)
|
||||
return false;
|
||||
}
|
||||
|
||||
if (!fit_check_format(sec_firmware_img)) {
|
||||
if (fit_check_format(sec_firmware_img, IMAGE_SIZE_INVAL)) {
|
||||
printf("SEC Firmware: Bad firmware image (bad FIT header)\n");
|
||||
return false;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user