arm: Don't include common.h in header files
It is bad practice to include common.h in other header files since it can bring in any number of superfluous definitions. It implies that some C files don't include it and thus may be missing CONFIG options that are set up by that file. The C files should include these themselves. Update some header files in arch/arm to drop this. Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
@@ -10,6 +10,7 @@
|
||||
#ifndef _CM_T54_MUX_DATA_H
|
||||
#define _CM_T54_MUX_DATA_H
|
||||
|
||||
#include <common.h>
|
||||
#include <asm/arch/mux_omap5.h>
|
||||
#include <asm/arch/sys_proto.h>
|
||||
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
* Based on other i.MX6 boards
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <init.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/imx-regs.h>
|
||||
|
||||
@@ -12,6 +12,7 @@
|
||||
* Copyright (C) 2013 Jon Nettleton <jon.nettleton@gmail.com>.
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <init.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/sys_proto.h>
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
* Author: Tim Harvey <tharvey@gateworks.com>
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/mx6-pins.h>
|
||||
#include <asm/arch/sys_proto.h>
|
||||
|
||||
@@ -4,6 +4,7 @@
|
||||
* Copyright (C) 2016 Grinn
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <command.h>
|
||||
#include <init.h>
|
||||
#include <asm/arch/clock.h>
|
||||
|
||||
@@ -11,6 +11,8 @@
|
||||
* (C) Copyright 2004-2008
|
||||
* Texas Instruments, <www.ti.com>
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <asm/io.h>
|
||||
#include <asm/arch/mem.h>
|
||||
#include <asm/arch/sys_proto.h>
|
||||
|
||||
@@ -3,6 +3,7 @@
|
||||
* Copyright (C) 2016 Stefano Babic <sbabic@denx.de>
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/imx-regs.h>
|
||||
#include <asm/arch/iomux.h>
|
||||
|
||||
@@ -13,6 +13,7 @@
|
||||
* Ported to SolidRun microSOM by Rabeeh Khoury <rabeeh@solid-run.com>
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <init.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/imx-regs.h>
|
||||
|
||||
@@ -6,6 +6,7 @@
|
||||
* Fabio Estevam <festevam@gmail.com>
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/imx-regs.h>
|
||||
#include <asm/arch/iomux.h>
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
* Author: Richard Hu <richard.hu@technexion.com>
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <cpu_func.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/imx-regs.h>
|
||||
|
||||
@@ -6,6 +6,7 @@
|
||||
* Based on board/wandboard/spl.c
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/imx-regs.h>
|
||||
#include <asm/arch/iomux.h>
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
* Richard Hu <hakahu@gmail.com>
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/imx-regs.h>
|
||||
#include <asm/arch/iomux.h>
|
||||
|
||||
@@ -6,6 +6,7 @@
|
||||
* Author: Fabio Estevam <fabio.estevam@freescale.com>
|
||||
*/
|
||||
|
||||
#include <common.h>
|
||||
#include <init.h>
|
||||
#include <asm/arch/clock.h>
|
||||
#include <asm/arch/crm_regs.h>
|
||||
|
||||
Reference in New Issue
Block a user