fec_mxc: incomplete error handling
fec_init() will only allocate fec->base_ptr if it is non-NULL. But the cleanup routine on error will free the pointer without setting it to NULL. This means that a later call to fec_init() would result in using an invalid pointer. Signed-off-by: John Ogness <john.ogness@linutronix.de> Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
This commit is contained in:
parent
2ab4a4d095
commit
c179a2896e
@ -450,6 +450,7 @@ static int fec_init(struct eth_device *dev, bd_t* bd)
|
||||
*/
|
||||
if (fec_rbd_init(fec, FEC_RBD_NUM, FEC_MAX_PKT_SIZE) < 0) {
|
||||
free(fec->base_ptr);
|
||||
fec->base_ptr = NULL;
|
||||
return -ENOMEM;
|
||||
}
|
||||
fec_tbd_init(fec);
|
||||
|
Loading…
Reference in New Issue
Block a user