leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: gem: Do not continue if phy is not found

Browse Source 
Add return value for phy detection algorithm to stop init function when
phy is not found.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Jagan Teki <jteki@openedev.com>
This commit is contained in:
Michal Simek 2015-11-30 13:38:32 +01:00
parent 3cbbc2574b
commit b904725a11
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/net/zynq_gem.c
View File

@ -241,7 +241,7 @@ static u32 phywrite(struct eth_device *dev, u32 phy_addr, u32 regnum, u16 data)
ZYNQ_GEM_PHYMNTNC_OP_W_MASK, &data);
}
static void phy_detection(struct eth_device *dev)
static int phy_detection(struct eth_device *dev)
{
int i;
u16 phyreg;
@ -254,7 +254,7 @@ static void phy_detection(struct eth_device *dev)
/* Found a valid PHY address */
debug("Default phy address %d is valid\n",
priv->phyaddr);
return;
return 0;
} else {
debug("PHY address is not setup correctly %d\n",
priv->phyaddr);
@ -272,11 +272,12 @@ static void phy_detection(struct eth_device *dev)
/* Found a valid PHY address */
priv->phyaddr = i;
debug("Found valid phy address, %d\n", i);
return;
return 0;
}
}
}
printf("PHY is not detected\n");
return -1;
}
static int zynq_gem_setup_mac(struct eth_device *dev)
@ -310,6 +311,7 @@ static int zynq_gem_setup_mac(struct eth_device *dev)
static int zynq_gem_init(struct eth_device *dev, bd_t * bis)
{
u32 i;
int ret;
unsigned long clk_rate = 0;
struct phy_device *phydev;
struct zynq_gem_regs *regs = (struct zynq_gem_regs *)dev->iobase;
@ -384,7 +386,11 @@ static int zynq_gem_init(struct eth_device *dev, bd_t * bis)
priv->init++;
}
phy_detection(dev);
ret = phy_detection(dev);
if (ret) {
printf("GEM PHY init failed\n");
return ret;
}
/* interface - look at tsec */
phydev = phy_connect(priv->bus, priv->phyaddr, dev,