leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rsa: check that pointer checksum isn't NULL before using it

Browse Source 
The pointer checksum were used before checking that it
isn't NULL. We move the code that use it after the check.

Reported-by: Coverity (CID: 185835)
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Philippe Reynes 2019-03-19 10:55:40 +01:00 committed by Tom Rini
parent cfb3e102c4
commit b02f2e79c6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/rsa/rsa-verify.c
View File

@ -295,7 +295,7 @@ static int rsa_verify_key(struct image_sign_info *info,
#endif
struct checksum_algo *checksum = info->checksum;
struct padding_algo *padding = info->padding;
int hash_len = checksum->checksum_len;
int hash_len;
if (!prop || !sig || !hash || !checksum)
return -EIO;
@ -315,6 +315,7 @@ static int rsa_verify_key(struct image_sign_info *info,
}
uint8_t buf[sig_len];
hash_len = checksum->checksum_len;
#if !defined(USE_HOSTCC)
ret = uclass_get_device(UCLASS_MOD_EXP, 0, &mod_exp_dev);