leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: cosmetic: Make the MAC address string less magical

Browse Source 
In u-boot printf has been extended with the %pM formatter to allow
printing of MAC addresses. However buffers that want to store a MAC
address cannot safely get the size. Add a define for this case so the
string of a MAC address can be reliably obtained.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
This commit is contained in:
oliver@schinagl.nl 2016-11-25 16:30:20 +01:00 committed by Joe Hershberger
parent a40db6d511
commit 9f455bcb34
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/net.h
View File

@ -40,6 +40,11 @@
/* ARP hardware address length */
#define ARP_HLEN 6
/*
* The size of a MAC address in string form, each digit requires two chars
* and five separator characters to form '00:00:00:00:00:00'.
*/
#define ARP_HLEN_ASCII (ARP_HLEN * 2) + (ARP_HLEN - 1)
/* IPv4 addresses are always 32 bits in size */
struct in_addr {

2
net/eth_common.c
View File

@ -32,7 +32,7 @@ int eth_getenv_enetaddr(const char *name, uchar *enetaddr)
int eth_setenv_enetaddr(const char *name, const uchar *enetaddr)
{
char buf[20];
char buf[ARP_HLEN_ASCII + 1];
sprintf(buf, "%pM", enetaddr);