leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dm: Improve errors and warnings in lists_bind_fdt()

Browse Source 
Add a debug message for when a device tree node has no driver. Also reword
the warning when a device fails to bind, which was misleading.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass
2014-07-23 06:55:22 -06:00
parent a327dee0f4
commit 9b0ba067f9
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/core/lists.c
View File

@@ -124,16 +124,19 @@ int lists_bind_fdt(struct udevice *parent, const void *blob, int offset)
const int n_ents = ll_entry_count(struct driver, driver); const int n_ents = ll_entry_count(struct driver, driver);
struct driver *entry; struct driver *entry;
struct udevice *dev; struct udevice *dev;
bool found = false;
const char *name; const char *name;
int result = 0; int result = 0;
int ret; int ret = 0;
dm_dbg("bind node %s\n", fdt_get_name(blob, offset, NULL)); dm_dbg("bind node %s\n", fdt_get_name(blob, offset, NULL));
for (entry = driver; entry != driver + n_ents; entry++) { for (entry = driver; entry != driver + n_ents; entry++) {
ret = driver_check_compatible(blob, offset, entry->of_match); ret = driver_check_compatible(blob, offset, entry->of_match);
name = fdt_get_name(blob, offset, NULL);
if (ret == -ENOENT) { if (ret == -ENOENT) {
continue; continue;
} else if (ret == -ENODEV) { } else if (ret == -ENODEV) {
dm_dbg("Device '%s' has no compatible string\n", name);
break; break;
} else if (ret) { } else if (ret) {
dm_warn("Device tree error at offset %d\n", offset); dm_warn("Device tree error at offset %d\n", offset);
@@ -142,14 +145,21 @@ int lists_bind_fdt(struct udevice *parent, const void *blob, int offset)
break; break;
} }
name = fdt_get_name(blob, offset, NULL);
dm_dbg(" - found match at '%s'\n", entry->name); dm_dbg(" - found match at '%s'\n", entry->name);
ret = device_bind(parent, entry, name, NULL, offset, &dev); ret = device_bind(parent, entry, name, NULL, offset, &dev);
if (ret) { if (ret) {
dm_warn("No match for driver '%s'\n", entry->name); dm_warn("Error binding driver '%s'\n", entry->name);
if (!result || ret != -ENOENT) if (!result || ret != -ENOENT)
result = ret; result = ret;
} else {
found = true;
} }
break;
}
if (!found && !result && ret != -ENODEV) {
dm_dbg("No match for node '%s'\n",
fdt_get_name(blob, offset, NULL));
} }
return result; return result;