leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spi: atcspi200: avoid NULL dereference

Browse Source 
For SPI_XFER_BEGIN | SPI_XFER_END the code sets data_out = NULL.
In the debug statement we should not dereference this value.
As we do not transfer any data the debug statement is not needed in this
case anyway.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Jagan Teki <jagan@openedev.com>
This commit is contained in:
Heinrich Schuchardt 2018-03-18 12:41:43 +01:00 committed by Jagan Teki
parent 4eaa2fa169
commit 8fad5e0b11
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spi/atcspi200_spi.c
View File

@ -229,8 +229,10 @@ static int __atcspi200_spi_xfer(struct nds_spi_slave *ns,
__atcspi200_spi_start(ns); __atcspi200_spi_start(ns);
break; break;
} }
if (data_out)
debug("spi_xfer: data_out %08X(%p) data_in %08X(%p) data_len %u\n", debug("spi_xfer: data_out %08X(%p) data_in %08X(%p) data_len %u\n",
*(uint *)data_out, data_out, *(uint *)data_in, data_in, data_len); *(uint *)data_out, data_out, *(uint *)data_in,
data_in, data_len);
num_chunks = DIV_ROUND_UP(data_len, max_tran_len); num_chunks = DIV_ROUND_UP(data_len, max_tran_len);
din = data_in; din = data_in;
dout = data_out; dout = data_out;