leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dfu: Fix memory leak in dfu_init_env_entities()

Browse Source 
In case of error in dfu_init_env_entities(), env_bkp will leak. Fix it
by providing single return path.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
This commit is contained in:
Sam Protsenko 2018-07-13 16:35:46 +03:00 committed by Marek Vasut
parent feaa7856f5
commit 87a8ca985b
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/dfu/dfu.c
View File

@ -56,7 +56,7 @@ int dfu_init_env_entities(char *interface, char *devstr)
{ {
const char *str_env; const char *str_env;
char *env_bkp; char *env_bkp;
int ret; int ret = 0;
#ifdef CONFIG_SET_DFU_ALT_INFO #ifdef CONFIG_SET_DFU_ALT_INFO
set_dfu_alt_info(interface, devstr); set_dfu_alt_info(interface, devstr);
@ -71,11 +71,12 @@ int dfu_init_env_entities(char *interface, char *devstr)
ret = dfu_config_entities(env_bkp, interface, devstr); ret = dfu_config_entities(env_bkp, interface, devstr);
if (ret) { if (ret) {
pr_err("DFU entities configuration failed!\n"); pr_err("DFU entities configuration failed!\n");
return ret; goto done;
} }
done:
free(env_bkp); free(env_bkp);
return 0; return ret;
} }
static unsigned char *dfu_buf; static unsigned char *dfu_buf;