leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: xhci-dwc3: Power on USB PHY before using

Browse Source 
It is wrong that expect .phy_init() to also power on the PHY. Therefore,
explicitly, call generic_phy_power_on() after generic_phy_power_init() in
order to power on PHY before using it.

Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Vignesh R 2018-03-07 14:50:08 +05:30 committed by Marek Vasut
parent 42637fdae8
commit 7d4e4d3063
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/usb/host/xhci-dwc3.c
View File

@ -137,6 +137,12 @@ static int xhci_dwc3_probe(struct udevice *dev)
pr_err("Can't init USB PHY for %s\n", dev->name);
return ret;
}
ret = generic_phy_power_on(&plat->usb_phy);
if (ret) {
pr_err("Can't power on USB PHY for %s\n", dev->name);
return ret;
}
}
dwc3_reg = (struct dwc3 *)((char *)(hccr) + DWC3_REG_OFFSET);
@ -159,6 +165,12 @@ static int xhci_dwc3_remove(struct udevice *dev)
int ret;
if (generic_phy_valid(&plat->usb_phy)) {
ret = generic_phy_power_off(&plat->usb_phy);
if (ret) {
pr_err("Can't poweroff USB PHY for %s\n", dev->name);
return ret;
}
ret = generic_phy_exit(&plat->usb_phy);
if (ret) {
pr_err("Can't deinit USB PHY for %s\n", dev->name);