leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

yaffs2: rework yaffs_new_obj_id

Browse Source 
The iterator variable of list_for_each is never NULL.
if (1 || A) is always true.
Use break if entry found.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
Heinrich Schuchardt 2017-11-09 01:26:43 +01:00 committed by Tom Rini
parent 65d87d6cfc
commit 76df275ce5
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
fs/yaffs2/yaffs_guts.c
View File

@ -1870,13 +1870,12 @@ static int yaffs_new_obj_id(struct yaffs_dev *dev)
while (!found) {
found = 1;
n += YAFFS_NOBJECT_BUCKETS;
if (1 || dev->obj_bucket[bucket].count > 0) {
list_for_each(i, &dev->obj_bucket[bucket].list) {
/* If there is already one in the list */
if (i && list_entry(i, struct yaffs_obj,
hash_link)->obj_id == n) {
found = 0;
}
list_for_each(i, &dev->obj_bucket[bucket].list) {
/* If there is already one in the list */
if (i && list_entry(i, struct yaffs_obj,
hash_link)->obj_id == n) {
found = 0;
break;
}
}
}