leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cmd: undefined return value of do_extension_apply()

Browse Source 
If 'extension apply all' is executed and no extension is found, the return
value of do_extension_apply() is undefined. Return CMD_RET_FAILURE in this
case.

Fixes: 2f84e9cf06 ("cmd: add support for a new "extension" command")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
This commit is contained in:
Heinrich Schuchardt 2022-07-11 20:01:12 +02:00 committed by Tom Rini
parent bf28d9a659
commit 689525b12e
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/extension_board.c
View File

@ -111,6 +111,7 @@ static int do_extension_apply(struct cmd_tbl *cmdtp, int flag,
return CMD_RET_USAGE; return CMD_RET_USAGE;
if (strcmp(argv[1], "all") == 0) { if (strcmp(argv[1], "all") == 0) {
ret = CMD_RET_FAILURE;
list_for_each_entry(extension, &extension_list, list) { list_for_each_entry(extension, &extension_list, list) {
ret = extension_apply(extension); ret = extension_apply(extension);
if (ret != CMD_RET_SUCCESS) if (ret != CMD_RET_SUCCESS)