leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pinctrl: renesas: Fix register usage in sh_pfc_{read,write}

Browse Source 
The sh_pfc_{read,write}() must operate on the register address directly
rather than on an offset, fix this to prevent illegal access.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
This commit is contained in:
Marek Vasut 2018-06-19 06:13:42 +02:00
parent 378b29cbc6
commit 5af6541972
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pinctrl/renesas/pfc.c
View File

@ -121,7 +121,7 @@ void sh_pfc_write_raw_reg(void __iomem *mapped_reg, unsigned int reg_width,
u32 sh_pfc_read(struct sh_pfc *pfc, u32 reg) u32 sh_pfc_read(struct sh_pfc *pfc, u32 reg)
{ {
return sh_pfc_read_raw_reg(pfc->regs + reg, 32); return sh_pfc_read_raw_reg((void __iomem *)(uintptr_t)reg, 32);
} }
void sh_pfc_write(struct sh_pfc *pfc, u32 reg, u32 data) void sh_pfc_write(struct sh_pfc *pfc, u32 reg, u32 data)
@ -132,7 +132,7 @@ void sh_pfc_write(struct sh_pfc *pfc, u32 reg, u32 data)
if (pfc->info->unlock_reg) if (pfc->info->unlock_reg)
sh_pfc_write_raw_reg(unlock_reg, 32, ~data); sh_pfc_write_raw_reg(unlock_reg, 32, ~data);
sh_pfc_write_raw_reg(pfc->regs + reg, 32, data); sh_pfc_write_raw_reg((void __iomem *)(uintptr_t)reg, 32, data);
} }
static void sh_pfc_config_reg_helper(struct sh_pfc *pfc, static void sh_pfc_config_reg_helper(struct sh_pfc *pfc,