leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SPL: tiny-printf: avoid any BSS usage

Browse Source 
As printf calls may be executed quite early, we should avoid using any
BSS stored variables, since some boards put BSS in DRAM, which may not
have been initialised yet.
Explicitly mark those "static global" variables as belonging to the
.data section, to keep tiny-printf clear of any BSS usage.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
This commit is contained in:
Andre Przywara 2016-07-08 15:18:35 +01:00 committed by Tom Rini
parent a82642f398
commit 59d07ee08e
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/tiny-printf.c
View File

@ -13,11 +13,16 @@
#include <stdarg.h> #include <stdarg.h>
#include <serial.h> #include <serial.h>
static char *bf; /*
static char zs; * This code in here may execute before the DRAM is initialised, so
* we should make sure that it doesn't touch BSS, which some boards
* put in DRAM.
*/
static char *bf __attribute__ ((section(".data")));
static char zs __attribute__ ((section(".data")));
/* Current position in sprintf() output string */ /* Current position in sprintf() output string */
static char *outstr; static char *outstr __attribute__ ((section(".data")));
static void out(char c) static void out(char c)
{ {