leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ram: ast2600: Fix incorrect statement of the register polling

Browse Source 
The condition "~data" in the if-statement is a typo.  The original
intention is to poll if SDRAM_PHYCTRL0_INIT bit equals to 0. So use
"data == 0" for instead.

Besides, the bit[1] of "phy_status" register is hardwired to
SDRAM_PHYCTRL0_INIT (with inverse logic). Since SDRAM_PHYCTRL0_INIT has
already done, remove the unnecessary checking of phy_status[1].

Fixes: fde9314346 ("ram: aspeed: Add AST2600 DRAM control support")
Review-by: Ryan Chen <ryan_chen@aspeedtech.com>
Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
This commit is contained in:
Dylan Hung
2022-11-11 15:30:06 +08:00
committed by Tom Rini
parent c246d69f31
commit 581df347db
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/ram/aspeed/sdram_ast2600.c
View File

@@ -449,7 +449,7 @@ static void ast2600_sdramphy_kick_training(struct dram_info *info)
while (1) { while (1) {
data = readl(&regs->phy_ctrl[0]) & SDRAM_PHYCTRL0_INIT; data = readl(&regs->phy_ctrl[0]) & SDRAM_PHYCTRL0_INIT;
if (~data) if (data == 0)
break; break;
} }
} }
@@ -984,11 +984,6 @@ static int ast2600_sdrammc_probe(struct udevice *dev)
L_ast2600_sdramphy_train: L_ast2600_sdramphy_train:
ast2600_sdrammc_init_ddr4(priv); ast2600_sdrammc_init_ddr4(priv);
/* make sure DDR-PHY is ready before access */
do {
reg = readl(priv->phy_status) & BIT(1);
} while (reg == 0);
if (ast2600_sdramphy_check_status(priv) != 0) { if (ast2600_sdramphy_check_status(priv) != 0) {
printf("DDR4 PHY training fail, retrain\n"); printf("DDR4 PHY training fail, retrain\n");
goto L_ast2600_sdramphy_train; goto L_ast2600_sdramphy_train;