watchdog: gpio_wdt: use __udelay() to avoid recursion
The udelay() function in lib/time.c contains a WATCHDOG_RESET()
call. The only reason this doesn't lead to a catastrophic infinite
recursion is due to the rate-limiting in wdt-uclass.c:
if (time_after_eq(now, priv->next_reset)) {
priv->next_reset = now + priv->reset_period;
wdt_reset(dev);
}
But this would fall apart if ->next_reset was updated after calling the
device's reset method.
This is needlessly fragile, and it's easy enough to avoid that
recursion in the first place by just using __udelay() directly.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Stefan Roese <sr@denx.de>
This commit is contained in:
committed by
Stefan Roese
parent
f117c54cc8
commit
51443c9a49
@@ -31,7 +31,7 @@ static int gpio_wdt_reset(struct udevice *dev)
|
||||
case HW_ALGO_LEVEL:
|
||||
/* Pulse */
|
||||
dm_gpio_set_value(&priv->gpio, 1);
|
||||
udelay(1);
|
||||
__udelay(1);
|
||||
dm_gpio_set_value(&priv->gpio, 0);
|
||||
break;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user