leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mkimage: error handling for FIT image

Browse Source 
If parameter -F is given but FIT support is missing, a NULL pointer might
dereferenced (Coverity CID 350249).

If incorrect parameters are given, provide a message and show usage.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
This commit is contained in:
Heinrich Schuchardt 2022-03-01 08:53:56 +01:00 committed by Tom Rini
parent 55fd1c442e
commit 5017f9b595
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/mkimage.c
View File

@ -381,6 +381,11 @@ int main(int argc, char **argv)
} }
if (params.fflag){ if (params.fflag){
if (!tparams) {
fprintf(stderr, "%s: Missing FIT support\n",
params.cmdname);
exit (EXIT_FAILURE);
}
if (tparams->fflag_handle) if (tparams->fflag_handle)
/* /*
* in some cases, some additional processing needs * in some cases, some additional processing needs
@ -391,7 +396,7 @@ int main(int argc, char **argv)
retval = tparams->fflag_handle(&params); retval = tparams->fflag_handle(&params);
if (retval != EXIT_SUCCESS) if (retval != EXIT_SUCCESS)
exit (retval); usage("Bad parameters for FIT image type");
} }
if (params.lflag || params.fflag) { if (params.lflag || params.fflag) {