leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mkimage: Ensure file is closed in fdt_property_file()

Browse Source 
The file that is opened is not closed in all cases. Fix it.

Reported-by: Coverity (CID: 138490)
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
This commit is contained in:
Simon Glass 2016-03-16 07:45:42 -06:00 committed by Tom Rini
parent 7b0bbd886d
commit 3bd3a54ac5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/fit_image.c
View File

@ -123,13 +123,14 @@ static int fdt_property_file(struct image_tool_params *params,
ret = fdt_property_placeholder(fdt, "data", sbuf.st_size, &ptr); ret = fdt_property_placeholder(fdt, "data", sbuf.st_size, &ptr);
if (ret) if (ret)
return ret; goto err;
ret = read(fd, ptr, sbuf.st_size); ret = read(fd, ptr, sbuf.st_size);
if (ret != sbuf.st_size) { if (ret != sbuf.st_size) {
fprintf(stderr, "%s: Can't read %s: %s\n", fprintf(stderr, "%s: Can't read %s: %s\n",
params->cmdname, fname, strerror(errno)); params->cmdname, fname, strerror(errno));
goto err; goto err;
} }
close(fd);
return 0; return 0;
err: err: