binman: Specify the toolpath when running test coverage
At present binman's test coverage runs without a toolpath set. This means that the system tools will be used. That may not be correct if they are out of date or missing and this can result in a reduction in test coverage below 100%. Provide the toolpath to binman in this case. Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
@@ -21,7 +21,8 @@ except:
|
||||
use_concurrent = False
|
||||
|
||||
|
||||
def RunTestCoverage(prog, filter_fname, exclude_list, build_dir, required=None):
|
||||
def RunTestCoverage(prog, filter_fname, exclude_list, build_dir, required=None,
|
||||
extra_args=None):
|
||||
"""Run tests and check that we get 100% coverage
|
||||
|
||||
Args:
|
||||
@@ -34,6 +35,8 @@ def RunTestCoverage(prog, filter_fname, exclude_list, build_dir, required=None):
|
||||
calculation
|
||||
build_dir: Build directory, used to locate libfdt.py
|
||||
required: List of modules which must be in the coverage report
|
||||
extra_args (str): Extra arguments to pass to the tool before the -t/test
|
||||
arg
|
||||
|
||||
Raises:
|
||||
ValueError if the code coverage is not 100%
|
||||
@@ -52,8 +55,8 @@ def RunTestCoverage(prog, filter_fname, exclude_list, build_dir, required=None):
|
||||
if build_dir:
|
||||
prefix = 'PYTHONPATH=$PYTHONPATH:%s/sandbox_spl/tools ' % build_dir
|
||||
cmd = ('%spython3-coverage run '
|
||||
'--omit "%s" %s %s -P1' % (prefix, ','.join(glob_list),
|
||||
prog, test_cmd))
|
||||
'--omit "%s" %s %s %s -P1' % (prefix, ','.join(glob_list),
|
||||
prog, extra_args or '', test_cmd))
|
||||
os.system(cmd)
|
||||
stdout = command.Output('python3-coverage', 'report')
|
||||
lines = stdout.splitlines()
|
||||
|
||||
Reference in New Issue
Block a user